immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25393] [MERGED] fix(web): handle deletion from asset viewer on map page #18192

New Issue
Closed
opened 2026-02-05 16:34:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:34:13 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25393
Author: @meesfrensel
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/21/2026
Merged by: @danieldietzler

Base: main ← Head: fix/map-delete-asset

📝 Commits (1)

  • 5a79195 fix(web): handle deletion from asset viewer on map page

📊 Changes

2 files changed (+13 additions, -0 deletions)

View changed files

📝 web/src/lib/components/asset-viewer/asset-viewer.svelte (+6 -0)
📝 web/src/lib/components/shared-components/map/map.svelte (+7 -0)

📄 Description

Description

Emit AssetsDelete event when deleting from the asset viewer & reload the map markers on this event.

I thought it was strange that the event wasn't emitted here yet, let me know if this is how you want to implement it.

Fixes #21412

How Has This Been Tested?

Tested by hand.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25393 **Author:** [@meesfrensel](https://github.com/meesfrensel) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/21/2026 **Merged by:** [@danieldietzler](https://github.com/danieldietzler) **Base:** `main` ← **Head:** `fix/map-delete-asset` --- ### 📝 Commits (1) - [`5a79195`](https://github.com/immich-app/immich/commit/5a79195e4fde097a731ec3b070a2e3cbebc91424) fix(web): handle deletion from asset viewer on map page ### 📊 Changes **2 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/asset-viewer/asset-viewer.svelte` (+6 -0) 📝 `web/src/lib/components/shared-components/map/map.svelte` (+7 -0) </details> ### 📄 Description ## Description Emit AssetsDelete event when deleting from the asset viewer & reload the map markers on this event. I thought it was strange that the event wasn't emitted here yet, let me know if this is how you want to implement it. Fixes #21412 ## How Has This Been Tested? Tested by hand. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:34:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18192
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?