immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25387] Cache shared link data on navigation #18191

New Issue
Open
opened 2026-02-05 16:34:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:34:13 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25387
Author: @integrii
Created: 1/20/2026
Status: 🔄 Open

Base: main ← Head: fix/shared-link-cache

📝 Commits (2)

  • 8f40e6a Fix shared link load cache
  • 7697cde Merge branch 'main' into fix/shared-link-cache

📊 Changes

1 file changed (+24 additions, -1 deletions)

View changed files

📝 web/src/lib/utils/shared-links.ts (+24 -1)

📄 Description

Description

Cache shared link data when navigating within the same shared link to avoid redundant getMySharedLink calls on return-to-album navigation. Asset info is still fetched when an assetId is present.

Fixes #22510

How Has This Been Tested?

  • pnpm install
  • pnpm --filter @immich/sdk build
  • CI=1 pnpm --filter immich-web test -- --run

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable (N/A - web-only change)
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable) (N/A - no new tests added for this UI change)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

Codex was used to draft and apply the code change and PR description.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25387 **Author:** [@integrii](https://github.com/integrii) **Created:** 1/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/shared-link-cache` --- ### 📝 Commits (2) - [`8f40e6a`](https://github.com/immich-app/immich/commit/8f40e6a150f15fad924cf2c6b32cf963d8160ccf) Fix shared link load cache - [`7697cde`](https://github.com/immich-app/immich/commit/7697cdee1f270cc03d56ff3f85b2a9f90c0e9940) Merge branch 'main' into fix/shared-link-cache ### 📊 Changes **1 file changed** (+24 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/utils/shared-links.ts` (+24 -1) </details> ### 📄 Description ## Description Cache shared link data when navigating within the same shared link to avoid redundant `getMySharedLink` calls on return-to-album navigation. Asset info is still fetched when an `assetId` is present. Fixes #22510 ## How Has This Been Tested? - [x] `pnpm install` - [x] `pnpm --filter @immich/sdk build` - [x] `CI=1 pnpm --filter immich-web test -- --run` <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> </details> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable (N/A - web-only change) - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) (N/A - no new tests added for this UI change) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. Codex was used to draft and apply the code change and PR description. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:34:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?