immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25293] fix: consider DAR when extracting video dimension #18154

New Issue
Open
opened 2026-02-05 16:33:35 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:33:35 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25293
Author: @alextran1502
Created: 1/16/2026
Status: 🔄 Open

Base: main ← Head: fix-consider-dar-for-video-dimension

📝 Commits (1)

  • 03e8f98 feat: consider DAR when extracting video dimension

📊 Changes

5 files changed (+82 additions, -5 deletions)

View changed files

📝 server/src/repositories/media.repository.ts (+1 -0)
📝 server/src/services/metadata.service.spec.ts (+15 -0)
📝 server/src/services/metadata.service.ts (+48 -5)
📝 server/src/types.ts (+1 -0)
📝 server/test/fixtures/media.stub.ts (+17 -0)

📄 Description

Curious from a GitHub issue report, I ask my man Claude to check if we can extract DAR from video and boom, he goes an extra mile. Will give a raise tmr.

Ref https://github.com/immich-app/immich/discussions/21724#discussioncomment-15508224

  • Pending actual testing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25293 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 1/16/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-consider-dar-for-video-dimension` --- ### 📝 Commits (1) - [`03e8f98`](https://github.com/immich-app/immich/commit/03e8f98c2ce595255479da1ba2ef4f0398ebb5f7) feat: consider DAR when extracting video dimension ### 📊 Changes **5 files changed** (+82 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `server/src/repositories/media.repository.ts` (+1 -0) 📝 `server/src/services/metadata.service.spec.ts` (+15 -0) 📝 `server/src/services/metadata.service.ts` (+48 -5) 📝 `server/src/types.ts` (+1 -0) 📝 `server/test/fixtures/media.stub.ts` (+17 -0) </details> ### 📄 Description Curious from a GitHub issue report, I ask my man Claude to check if we can extract DAR from video and boom, he goes an extra mile. Will give a raise tmr. Ref https://github.com/immich-app/immich/discussions/21724#discussioncomment-15508224 - [ ] Pending actual testing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:33:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?