immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-15 21:32:32 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25232] feat(people): sort unknown faces by number of assets #18122

New Issue
Open
opened 2026-02-05 16:33:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:33:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25232
Author: @codesterribly
Created: 1/13/2026
Status: 🔄 Open

Base: main ← Head: feat/unknown-faces-sort-by-asset-count

📝 Commits (2)

  • 8bb9ebc feat(people): sort unknown faces by number of assets
  • d7af645 Merge branch 'main' into feat/unknown-faces-sort-by-asset-count

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 server/src/repositories/person.repository.ts (+10 -1)

📄 Description

Description

Summary

Sort unknown faces by the number of distinct assets they appear in, while preserving existing ordering rules.

Behavior

  • Known people remain listed first
  • Unknown people appear after known
  • Unknown people are sorted by number of distinct assets (descending)
  • Ties are broken by raw face detection count
  • Sorting is skipped when closest-face similarity sorting is active

Motivation

Frequently occurring unknown faces (e.g. recurring family members without a name)
are easier to identify and label when surfaced first.

Fixes # (issue)

How Has This Been Tested?

Testing seemed to work, but I am working in an unclean env with lots of other changes.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25232 **Author:** [@codesterribly](https://github.com/codesterribly) **Created:** 1/13/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/unknown-faces-sort-by-asset-count` --- ### 📝 Commits (2) - [`8bb9ebc`](https://github.com/immich-app/immich/commit/8bb9ebc3c1388460ae2b6908ea07e7ee620f5767) feat(people): sort unknown faces by number of assets - [`d7af645`](https://github.com/immich-app/immich/commit/d7af645067ece7ff973c90b86c9640018f04e60a) Merge branch 'main' into feat/unknown-faces-sort-by-asset-count ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/src/repositories/person.repository.ts` (+10 -1) </details> ### 📄 Description ## Description ### Summary Sort unknown faces by the number of distinct assets they appear in, while preserving existing ordering rules. ### Behavior - Known people remain listed first - Unknown people appear after known - Unknown people are sorted by number of distinct assets (descending) - Ties are broken by raw face detection count - Sorting is skipped when closest-face similarity sorting is active ### Motivation Frequently occurring unknown faces (e.g. recurring family members without a name) are easier to identify and label when surfaced first. Fixes # (issue) ## How Has This Been Tested? Testing seemed to work, but I am working in an unclean env with lots of other changes. ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [ ] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. ... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:33:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18122
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?