immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #24670] fix(cli): allow easily crawling paths with parentheses #17958

New Issue
Open
opened 2026-02-05 16:30:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:30:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/24670
Author: @meesfrensel
Created: 12/18/2025
Status: 🔄 Open

Base: main ← Head: fix/crawl-parentheses

📝 Commits (1)

  • 26ffd43 fix(cli): allow easily crawling paths with parentheses

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 cli/src/utils.spec.ts (+9 -0)
📝 cli/src/utils.ts (+6 -1)

📄 Description

Description

Escape parentheses in glob paths.

This might technically be a regression for users that use the (a|b) regex/glob syntax. I didn't see any explicit note of that anywhere in the cli docs, and folder/album names with years are a reasonably common use case I'd say.

If not desired I'll open another PR specifying what to expect from the globbed inputs and how to crawl folders with e.g. parentheses.

Fixes #23885

How Has This Been Tested?

Added a unit test for the crawl.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/24670 **Author:** [@meesfrensel](https://github.com/meesfrensel) **Created:** 12/18/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/crawl-parentheses` --- ### 📝 Commits (1) - [`26ffd43`](https://github.com/immich-app/immich/commit/26ffd431fe0ef5450b8275d005cb5d395b407935) fix(cli): allow easily crawling paths with parentheses ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cli/src/utils.spec.ts` (+9 -0) 📝 `cli/src/utils.ts` (+6 -1) </details> ### 📄 Description ## Description Escape parentheses in glob paths. This might technically be a regression for users that use the `(a|b)` regex/glob syntax. I didn't see any explicit note of that anywhere in the cli docs, and folder/album names with years are a reasonably common use case I'd say. If not desired I'll open another PR specifying what to expect from the globbed inputs and how to crawl folders with e.g. parentheses. Fixes #23885 ## How Has This Been Tested? Added a unit test for the crawl. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:30:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17958
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?