immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #24648] feat(mobile): show activity count on the activity button label #17952

New Issue
Open
opened 2026-02-05 16:30:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:30:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/24648
Author: @idubnori
Created: 12/17/2025
Status: 🔄 Open

Base: feature/bottom-buttons-order ← Head: feature/show-activity-count

📝 Commits (3)

  • 3e86354 Merge remote-tracking branch 'origin/main' into feature/show-activity-count
  • d63a1bc feat(mobile): add the number of activities to the activity button label
  • e508844 Merge branch 'feature/bottom-buttons-order' into feature/show-activity-count

📊 Changes

12 files changed (+50 additions, -29 deletions)

View changed files

📝 i18n/en.json (+1 -0)
📝 i18n/ja.json (+1 -0)
📝 mobile/lib/models/activities/activity.model.dart (+4 -1)
📝 mobile/lib/presentation/widgets/action_buttons/open_activity_action_button.widget.dart (+9 -1)
📝 mobile/lib/providers/activity.provider.dart (+9 -5)
📝 mobile/lib/providers/activity.provider.g.dart (+1 -1)
📝 mobile/lib/providers/activity_statistics.provider.dart (+2 -2)
📝 mobile/lib/providers/activity_statistics.provider.g.dart (+7 -7)
📝 mobile/lib/repositories/activity_api.repository.dart (+1 -1)
📝 mobile/lib/services/activity.service.dart (+1 -1)
📝 mobile/test/modules/activity/activity_provider_test.dart (+9 -7)
📝 mobile/test/modules/activity/activity_statistics_provider_test.dart (+5 -3)

📄 Description

Description

  • details: ScreenShots section
  • note: in gphotos, label name is “comment” and displays only the number of comments.
    in immich, includes the number of likes as well

How Has This Been Tested?

unit tests

  • fix / improve related to like count handling

manually tests on iOS simurator

  • added or removed likes or comments, confirmed the activity count updates

Screenshots (if appropriate)

https://github.com/user-attachments/assets/d9e4814a-458e-44b7-9c99-cc8edbafbd5b

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

most of impl, under my direction and review

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/24648 **Author:** [@idubnori](https://github.com/idubnori) **Created:** 12/17/2025 **Status:** 🔄 Open **Base:** `feature/bottom-buttons-order` ← **Head:** `feature/show-activity-count` --- ### 📝 Commits (3) - [`3e86354`](https://github.com/immich-app/immich/commit/3e8635431e8b92604ded99d2def989f42f03f36b) Merge remote-tracking branch 'origin/main' into feature/show-activity-count - [`d63a1bc`](https://github.com/immich-app/immich/commit/d63a1bcd07f70909c13b8a2256c6754eea23dd75) feat(mobile): add the number of activities to the activity button label - [`e508844`](https://github.com/immich-app/immich/commit/e5088440be154018c2e97a45620583e94fd47983) Merge branch 'feature/bottom-buttons-order' into feature/show-activity-count ### 📊 Changes **12 files changed** (+50 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `i18n/en.json` (+1 -0) 📝 `i18n/ja.json` (+1 -0) 📝 `mobile/lib/models/activities/activity.model.dart` (+4 -1) 📝 `mobile/lib/presentation/widgets/action_buttons/open_activity_action_button.widget.dart` (+9 -1) 📝 `mobile/lib/providers/activity.provider.dart` (+9 -5) 📝 `mobile/lib/providers/activity.provider.g.dart` (+1 -1) 📝 `mobile/lib/providers/activity_statistics.provider.dart` (+2 -2) 📝 `mobile/lib/providers/activity_statistics.provider.g.dart` (+7 -7) 📝 `mobile/lib/repositories/activity_api.repository.dart` (+1 -1) 📝 `mobile/lib/services/activity.service.dart` (+1 -1) 📝 `mobile/test/modules/activity/activity_provider_test.dart` (+9 -7) 📝 `mobile/test/modules/activity/activity_statistics_provider_test.dart` (+5 -3) </details> ### 📄 Description ## Description - details: `ScreenShots` section - note: in gphotos, label name is “comment” and displays only the number of comments. in immich, includes the number of likes as well <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> ### unit tests - [x] fix / improve related to like count handling ### manually tests on iOS simurator - [x] added or removed likes or comments, confirmed the activity count updates <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> https://github.com/user-attachments/assets/d9e4814a-458e-44b7-9c99-cc8edbafbd5b </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [ ] I have performed a self-review of my own code - [ ] ~I have made corresponding changes to the documentation if applicable~ - [ ] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [ ] ~All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc.~ - [ ] ~All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)~ ## Please describe to which degree, if any, an LLM was used in creating this pull request. most of impl, under my direction and review --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:30:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?