immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #24641] fix(web): Enable stack selector in shared album view #17948

New Issue
Open
opened 2026-02-05 16:30:07 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:30:07 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/24641
Author: @timonrieger
Created: 12/17/2025
Status: 🔄 Open

Base: main ← Head: fix/web-shared-album-stack-selector

📝 Commits (1)

  • 31ac0e8 fix(web): Enable stack selector in shared album view

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte (+1 -0)

📄 Description

Description

Enables the stack selector in shared album views for asset owners. Previously, stacked photos in shared albums didn't show the stack selector, preventing navigation through stacked assets.

Note: This fix applies to the asset owner (the person who uploaded/owns the assets), not the album owner. Members viewing shared albums will still only see the single shared image (not the stack selector) until backend permission checks are updated to allow stack access through album membership.

Fixes #15760

How Has This Been Tested?

  • Created a stack of photos and added them to a shared album
  • Verified the stack selector appears when viewing the album as the owner of the added image
  • Confirmed members of the shared album still only see the single shared image (expected behavior until backend fix)

Screenshots

Before fix
image

After fix
Screenshot 2025-12-17 at 13 09 12

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

Used AI assistance to identify the root cause (missing withStacked prop) and understand the relationship between frontend stack display and backend permission checks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/24641 **Author:** [@timonrieger](https://github.com/timonrieger) **Created:** 12/17/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/web-shared-album-stack-selector` --- ### 📝 Commits (1) - [`31ac0e8`](https://github.com/immich-app/immich/commit/31ac0e8f09d2f9fb0bcb7e7cd82d3a645d6505e6) fix(web): Enable stack selector in shared album view ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+1 -0) </details> ### 📄 Description ## Description Enables the stack selector in shared album views for asset owners. Previously, stacked photos in shared albums didn't show the stack selector, preventing navigation through stacked assets. **Note:** This fix applies to the asset owner (the person who uploaded/owns the assets), not the album owner. Members viewing shared albums will still only see the single shared image (not the stack selector) until backend permission checks are updated to allow stack access through album membership. Fixes #15760 ## How Has This Been Tested? - [x] Created a stack of photos and added them to a shared album - [x] Verified the stack selector appears when viewing the album as the owner of the added image - [x] Confirmed members of the shared album still only see the single shared image (expected behavior until backend fix) <details><summary><h2>Screenshots</h2></summary> <!-- Images go below this line. --> **Before fix** <img width="1339" height="882" alt="image" src="https://github.com/user-attachments/assets/5c11e3f0-c8cd-4cc2-8861-41f1c8236425" /> **After fix** <img width="1344" height="897" alt="Screenshot 2025-12-17 at 13 09 12" src="https://github.com/user-attachments/assets/33e9270c-9ad0-4579-9360-b30928652538" /> </details> ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. Used AI assistance to identify the root cause (missing `withStacked` prop) and understand the relationship between frontend stack display and backend permission checks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:30:07 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17948
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?