immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #24453] [CLOSED] fix(server): people count doesn't match array #17876

New Issue
Closed
opened 2026-02-05 16:28:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:28:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/24453
Author: @YarosMallorca
Created: 12/8/2025
Status: ❌ Closed

Base: main ← Head: fix/all-people-count

📝 Commits (5)

  • a53ba93 fix(server): people count doesn't match array
  • 6d8c166 chore: update sql query file
  • f1111bb chore: adjusted e2e tests
  • 4277b50 chore: update comment
  • 6ac3d8e refactor: merge into one query

📊 Changes

5 files changed (+103 additions, -140 deletions)

View changed files

📝 e2e/src/api/specs/person.e2e-spec.ts (+4 -4)
📝 server/src/queries/person.repository.sql (+0 -64)
📝 server/src/repositories/person.repository.ts (+51 -63)
📝 server/src/services/person.service.spec.ts (+41 -4)
📝 server/src/services/person.service.ts (+7 -5)

📄 Description

Description

Server-side fix for #24434

The total and hidden count in the people endpoint was inconsistent with the actual array, as people who were automatically "hidden" because of a lack of assets still counted (I assume this was unintentional and not the desired behavior).

Potentially breaking change

Not sure if this is the preferred fix, feel free to suggest better solutions :)

How Has This Been Tested?

  • Upload photos to the server, let it do ML for faces, and make sure that at least one of the faces doesn't have enough assets
  • Call the people endpoint, manually check the number of people returned in the array, and the counts below

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/24453 **Author:** [@YarosMallorca](https://github.com/YarosMallorca) **Created:** 12/8/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/all-people-count` --- ### 📝 Commits (5) - [`a53ba93`](https://github.com/immich-app/immich/commit/a53ba9381f372417babb599dfec688bbc02491d4) fix(server): people count doesn't match array - [`6d8c166`](https://github.com/immich-app/immich/commit/6d8c166d866ee493b52261968d684254ec2696f6) chore: update sql query file - [`f1111bb`](https://github.com/immich-app/immich/commit/f1111bbc62c80b700942206e33b27cb404a75237) chore: adjusted e2e tests - [`4277b50`](https://github.com/immich-app/immich/commit/4277b500ac1e43ab1b1d88fffc6c31b55f298538) chore: update comment - [`6ac3d8e`](https://github.com/immich-app/immich/commit/6ac3d8e4c6f9958a5699102d727e9d07fcbc55d8) refactor: merge into one query ### 📊 Changes **5 files changed** (+103 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `e2e/src/api/specs/person.e2e-spec.ts` (+4 -4) 📝 `server/src/queries/person.repository.sql` (+0 -64) 📝 `server/src/repositories/person.repository.ts` (+51 -63) 📝 `server/src/services/person.service.spec.ts` (+41 -4) 📝 `server/src/services/person.service.ts` (+7 -5) </details> ### 📄 Description ## Description Server-side fix for #24434 The total and hidden count in the `people` endpoint was inconsistent with the actual array, as people who were automatically "hidden" because of a lack of assets still counted (I assume this was unintentional and not the desired behavior). **Potentially breaking change** _Not sure if this is the preferred fix, feel free to suggest better solutions :)_ ## How Has This Been Tested? - [x] Upload photos to the server, let it do ML for faces, and make sure that at least one of the faces doesn't have enough assets - [x] Call the `people` endpoint, manually check the number of people returned in the array, and the counts below --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:28:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?