immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #23887] [CLOSED] Add album management and file upload limits #17673

New Issue
Closed
opened 2026-02-05 16:25:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:25:42 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/23887
Author: @LuckyCoders
Created: 11/14/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (7)

  • 12afea6 Checkpoint before follow-up message
  • 44cb10b Checkpoint before follow-up message
  • f05fb98 feat: Add upload limit and improve album actions
  • ab405e1 Checkpoint before follow-up message
  • c11eccd Checkpoint before follow-up message
  • de35c0d Merge pull request #2 from LuckyCoders/cursor/bc-defcafd1-530c-4a34-b7e6-e6c77251fffe-6422
  • 41d4482 Merge pull request #1 from LuckyCoders/cursor/add-album-management-and-file-upload-limits-44ec

📊 Changes

83 files changed (+1608 additions, -256 deletions)

View changed files

📝 i18n/af.json (+11 -2)
📝 i18n/ar.json (+10 -3)
📝 i18n/az.json (+11 -2)
📝 i18n/be.json (+11 -2)
📝 i18n/bg.json (+10 -3)
📝 i18n/bi.json (+11 -2)
📝 i18n/bn.json (+10 -1)
📝 i18n/ca.json (+10 -3)
📝 i18n/cs.json (+10 -3)
📝 i18n/cv.json (+11 -2)
📝 i18n/da.json (+10 -3)
📝 i18n/de.json (+10 -3)
📝 i18n/el.json (+10 -3)
📝 i18n/en.json (+26 -3)
📝 i18n/es.json (+10 -3)
📝 i18n/et.json (+10 -3)
📝 i18n/eu.json (+11 -2)
📝 i18n/fa.json (+11 -2)
📝 i18n/fi.json (+10 -3)
📝 i18n/fil.json (+11 -2)

...and 63 more files

📄 Description

Description

This PR significantly enhances the asset management user experience by introducing a unified "Add to" menu.

  • Replaces the previous "Add to album" modals with a single inline dropdown, accessible via a "+ Add to" button.
  • The new dropdown lists all user-owned and shared albums, allowing assets to be added or removed using checkboxes, and indicates partial album membership.
  • Provides an integrated option to create a new album, automatically including the currently selected assets.
  • The "Archive" and "Locked folder" (Set Visibility) actions are now directly integrated into this "Add to" dropdown, removing their dedicated buttons from main toolbars (timeline, favorites, search, partners, people) and the asset viewer's "More" menu.
  • Includes new i18n keys for the updated UI elements across all locales.
  • Cloudflare free tier don't allow upload files more 100 MB for 1 request. In this update we make filter for media size.. mb later need to make chunked upload.

Fixes # (issue)

How Has This Been Tested?

  • Manual UI smoke test:
    • Open "Add to" dropdown on timeline, favorites, search, people, partners pages, and the asset viewer.
    • Verify all owned and shared albums are listed.
    • Add/remove assets from albums using checkboxes.
    • Create a new album with selected assets.
    • Verify Archive and Locked actions are present and functional within the "Add to" menu.
    • Confirm dedicated Archive and Locked buttons are removed from other menus.

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

An LLM was used to generate and refine the code based on user instructions and feedback.

Open in Cursor Open in Web

Note

Introduce a unified Add to dropdown to add/remove assets to albums, create albums, and access archive/visibility; replace old modals/usages and add i18n strings.

  • UI/Frontend:
    • New AddToMenuContent.svelte: Inline dropdown to add/remove selected assets to albums (shows full/partial membership, counts), search albums, and create a new album; disables for locked assets.
    • Usage updates: Replace AddToAlbumAction with AddToMenuContent in favorites, people, photos, and search pages; move ArchiveAction and SetVisibilityAction into the Add to menu and remove them from overflow menus.
  • i18n:
    • Add keys for Add to menu states (add_to_menu_*, errors.unable_to_add_to_album, errors.unable_to_load_albums) across all locales.

Written by Cursor Bugbot for commit c11eccdc79. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/23887 **Author:** [@LuckyCoders](https://github.com/LuckyCoders) **Created:** 11/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (7) - [`12afea6`](https://github.com/immich-app/immich/commit/12afea603c60e890b75ddc86777c44d2a9fba18e) Checkpoint before follow-up message - [`44cb10b`](https://github.com/immich-app/immich/commit/44cb10b84ea11d593d99ced188d8cf2d8bf3f3e0) Checkpoint before follow-up message - [`f05fb98`](https://github.com/immich-app/immich/commit/f05fb98731fc309c8a3e797448f7713f8d719ed9) feat: Add upload limit and improve album actions - [`ab405e1`](https://github.com/immich-app/immich/commit/ab405e107b774322095445ddb0c8b4946e64fe1d) Checkpoint before follow-up message - [`c11eccd`](https://github.com/immich-app/immich/commit/c11eccdc79854a785a11921abb15ce4371ceaeba) Checkpoint before follow-up message - [`de35c0d`](https://github.com/immich-app/immich/commit/de35c0d2fd2081ee422906b5f93e38ef617415e4) Merge pull request #2 from LuckyCoders/cursor/bc-defcafd1-530c-4a34-b7e6-e6c77251fffe-6422 - [`41d4482`](https://github.com/immich-app/immich/commit/41d4482ef498662af5397a56ece9239ed6338225) Merge pull request #1 from LuckyCoders/cursor/add-album-management-and-file-upload-limits-44ec ### 📊 Changes **83 files changed** (+1608 additions, -256 deletions) <details> <summary>View changed files</summary> 📝 `i18n/af.json` (+11 -2) 📝 `i18n/ar.json` (+10 -3) 📝 `i18n/az.json` (+11 -2) 📝 `i18n/be.json` (+11 -2) 📝 `i18n/bg.json` (+10 -3) 📝 `i18n/bi.json` (+11 -2) 📝 `i18n/bn.json` (+10 -1) 📝 `i18n/ca.json` (+10 -3) 📝 `i18n/cs.json` (+10 -3) 📝 `i18n/cv.json` (+11 -2) 📝 `i18n/da.json` (+10 -3) 📝 `i18n/de.json` (+10 -3) 📝 `i18n/el.json` (+10 -3) 📝 `i18n/en.json` (+26 -3) 📝 `i18n/es.json` (+10 -3) 📝 `i18n/et.json` (+10 -3) 📝 `i18n/eu.json` (+11 -2) 📝 `i18n/fa.json` (+11 -2) 📝 `i18n/fi.json` (+10 -3) 📝 `i18n/fil.json` (+11 -2) _...and 63 more files_ </details> ### 📄 Description ## Description This PR significantly enhances the asset management user experience by introducing a unified "Add to" menu. * Replaces the previous "Add to album" modals with a single inline dropdown, accessible via a "+ Add to" button. * The new dropdown lists all user-owned and shared albums, allowing assets to be added or removed using checkboxes, and indicates partial album membership. * Provides an integrated option to create a new album, automatically including the currently selected assets. * The "Archive" and "Locked folder" (Set Visibility) actions are now directly integrated into this "Add to" dropdown, removing their dedicated buttons from main toolbars (timeline, favorites, search, partners, people) and the asset viewer's "More" menu. * Includes new i18n keys for the updated UI elements across all locales. * Cloudflare free tier don't allow upload files more 100 MB for 1 request. In this update we make filter for media size.. mb later need to make chunked upload. Fixes # (issue) ## How Has This Been Tested? - [x] Manual UI smoke test: - Open "Add to" dropdown on timeline, favorites, search, people, partners pages, and the asset viewer. - Verify all owned and shared albums are listed. - Add/remove assets from albums using checkboxes. - Create a new album with selected assets. - Verify Archive and Locked actions are present and functional within the "Add to" menu. - Confirm dedicated Archive and Locked buttons are removed from other menus. <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. An LLM was used to generate and refine the code based on user instructions and feedback. --- <a href="https://cursor.com/background-agent?bcId=bc-defcafd1-530c-4a34-b7e6-e6c77251fffe"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-defcafd1-530c-4a34-b7e6-e6c77251fffe"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduce a unified Add to dropdown to add/remove assets to albums, create albums, and access archive/visibility; replace old modals/usages and add i18n strings. > > - **UI/Frontend**: > - **New `AddToMenuContent.svelte`**: Inline dropdown to add/remove selected assets to albums (shows full/partial membership, counts), search albums, and create a new album; disables for locked assets. > - **Usage updates**: Replace `AddToAlbumAction` with `AddToMenuContent` in `favorites`, `people`, `photos`, and `search` pages; move `ArchiveAction` and `SetVisibilityAction` into the Add to menu and remove them from overflow menus. > - **i18n**: > - Add keys for Add to menu states (`add_to_menu_*`, `errors.unable_to_add_to_album`, `errors.unable_to_load_albums`) across all locales. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c11eccdc79854a785a11921abb15ce4371ceaeba. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:25:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?