immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #23755] [MERGED] fix(mobile): Set dynamic height of actions row in BottomSheet #17612

New Issue
Closed
opened 2026-02-05 16:24:45 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:24:45 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/23755
Author: @vitoksmile
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @alextran1502

Base: main ← Head: fix/mobile-bottom-sheet-actions-height

📝 Commits (2)

  • 0011dad fix(mobile): Set dynamic height of actions row in BottomSheet
  • 0a9f7a4 Merge branch 'main' into fix/mobile-bottom-sheet-actions-height

📊 Changes

1 file changed (+3 additions, -7 deletions)

View changed files

📝 mobile/lib/presentation/widgets/bottom_sheet/base_bottom_sheet.widget.dart (+3 -7)

📄 Description

Description

Fixes extra padding of actions row in BottomSheet

How Has This Been Tested?

  • Navigate to Photos tab
  • Select any photo
  • Scroll down (or click on menu icon) to open bottom sheet
  • Long press on any of actions (e.g. View similar photos)

Screenshots

Actual behaviour:

Fixed behaviour:

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

No LLM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/23755 **Author:** [@vitoksmile](https://github.com/vitoksmile) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/mobile-bottom-sheet-actions-height` --- ### 📝 Commits (2) - [`0011dad`](https://github.com/immich-app/immich/commit/0011dadfd4f0589d2628b959e379d7e9214c2ace) fix(mobile): Set dynamic height of actions row in BottomSheet - [`0a9f7a4`](https://github.com/immich-app/immich/commit/0a9f7a45e64df0dd6bf63ed1fe1e04fdb495884c) Merge branch 'main' into fix/mobile-bottom-sheet-actions-height ### 📊 Changes **1 file changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/presentation/widgets/bottom_sheet/base_bottom_sheet.widget.dart` (+3 -7) </details> ### 📄 Description ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Fixes extra padding of actions row in BottomSheet ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - Navigate to Photos tab - Select any photo - Scroll down (or click on menu icon) to open bottom sheet - Long press on any of actions (e.g. View similar photos) <details><summary><h2>Screenshots</h2></summary> <!-- Images go below this line. --> Actual behaviour: <img width="240" src="https://github.com/user-attachments/assets/27b78907-1804-4d3e-a629-22f338e735cd" /> Fixed behaviour: <img width="240" src="https://github.com/user-attachments/assets/54e87b68-5e58-4969-866f-e02973893b15" /> </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [X] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [X] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [X] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. No LLM --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:24:45 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17612
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?