immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #23550] [MERGED] fix(web): search bar accessibility #17558

New Issue
Closed
opened 2026-02-05 16:23:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:23:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/23550
Author: @ben-basten
Created: 11/3/2025
Status: ✅ Merged
Merged: 11/3/2025
Merged by: @jrasm91

Base: main ← Head: ben/search-bar-a11y

📝 Commits (2)

  • 0e15cff fix: always show search type when search bar is focused
  • ccfa2fa fix: indicate search type to screen reader users

📊 Changes

1 file changed (+6 additions, -7 deletions)

View changed files

📝 web/src/lib/components/shared-components/search-bar/search-bar.svelte (+6 -7)

📄 Description

Description

Announce the search type to screen reader users to provide a similar experience as the blue label provides in the visual search bar.

Also always keep the blue search type label visible while the search bar is active, regardless of whether the dropdown menu is open or not.

How Has This Been Tested?

Tested the search bar with VoiceOver on MacOS, in the Safari, Firefox, and Chrome browsers.

Screenshots

 Screenshot 2025-11-03 at 07 16 36

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please describe to which degree, if any, an LLM was used in creating this pull request.

None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/23550 **Author:** [@ben-basten](https://github.com/ben-basten) **Created:** 11/3/2025 **Status:** ✅ Merged **Merged:** 11/3/2025 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `ben/search-bar-a11y` --- ### 📝 Commits (2) - [`0e15cff`](https://github.com/immich-app/immich/commit/0e15cff040acb0fafa28b2b974f92cfce87bcc2e) fix: always show search type when search bar is focused - [`ccfa2fa`](https://github.com/immich-app/immich/commit/ccfa2fa8e9a7526649a3d7d0ca2223fa16954c3e) fix: indicate search type to screen reader users ### 📊 Changes **1 file changed** (+6 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/shared-components/search-bar/search-bar.svelte` (+6 -7) </details> ### 📄 Description ## Description Announce the search type to screen reader users to provide a similar experience as the blue label provides in the visual search bar. Also always keep the blue search type label visible while the search bar is active, regardless of whether the dropdown menu is open or not. ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Tested the search bar with VoiceOver on MacOS, in the Safari, Firefox, and Chrome browsers. <details><summary><h2>Screenshots</h2></summary> <!-- Images go below this line. --> <img width="1273" height="207" alt="Screenshot 2025-11-03 at 07 16 36" src="https://github.com/user-attachments/assets/7ed7fb91-097d-40d5-8384-2004124ed3c1" /> </details> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code ## Please describe to which degree, if any, an LLM was used in creating this pull request. None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:23:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?