immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #23396] [MERGED] chore(server): clarify asset copy parameters #17526

New Issue
Closed
opened 2026-02-05 16:23:22 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:23:22 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/23396
Author: @etnoy
Created: 10/31/2025
Status: ✅ Merged
Merged: 10/31/2025
Merged by: @danieldietzler

Base: main ← Head: fix/asset-service-argument-order

📝 Commits (1)

  • e19467e fix(server): improved method signatures for stack and sidecar copying

📊 Changes

1 file changed (+22 additions, -16 deletions)

View changed files

📝 server/src/services/asset.service.ts (+22 -16)

📄 Description

Fix variable name confusion in copySidecar

Turns arguments of copySidecar and copyStack into objects, preventing this in the future.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/23396 **Author:** [@etnoy](https://github.com/etnoy) **Created:** 10/31/2025 **Status:** ✅ Merged **Merged:** 10/31/2025 **Merged by:** [@danieldietzler](https://github.com/danieldietzler) **Base:** `main` ← **Head:** `fix/asset-service-argument-order` --- ### 📝 Commits (1) - [`e19467e`](https://github.com/immich-app/immich/commit/e19467edddcc813c20609dd4c3bdf45f86df9d15) fix(server): improved method signatures for stack and sidecar copying ### 📊 Changes **1 file changed** (+22 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `server/src/services/asset.service.ts` (+22 -16) </details> ### 📄 Description Fix variable name confusion in copySidecar Turns arguments of copySidecar and copyStack into objects, preventing this in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:23:22 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?