immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #23217] [MERGED] fix: incomplete dynamic imports #17469

New Issue
Closed
opened 2026-02-05 16:22:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:22:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/23217
Author: @midzelis
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/27/2025
Merged by: @jrasm91

Base: main ← Head: fix/imcomplete_dynamic_imports

📝 Commits (1)

  • 7b1c91f fix: incomplete dynamic imports

📊 Changes

8 files changed (+69 additions, -49 deletions)

View changed files

📝 web/src/lib/components/asset-viewer/detail-panel.svelte (+4 -4)
📝 web/src/lib/components/share-page/individual-shared-viewer.svelte (+11 -10)
📝 web/src/lib/components/shared-components/change-location.svelte (+1 -1)
📝 web/src/lib/components/shared-components/gallery-viewer/gallery-viewer.svelte (+13 -12)
📝 web/src/lib/components/shared-components/map/map.svelte (+23 -14)
📝 web/src/lib/components/timeline/TimelineAssetViewer.svelte (+1 -1)
📝 web/src/lib/modals/MapModal.svelte (+1 -1)
📝 web/src/routes/(user)/map/[[photos=photos]]/[[assetId=id]]/+page.svelte (+15 -6)

📄 Description

For dynamic imports to work as intended, EVERY usage of a candidate dynamic import component must be dynamically imported.

The current dynamically imported components in Immich are:

  • map.svelte
  • asset-viewer.svelte
  • photo-sphere-viewer-adapter.svelte

This PR fixes:

  • map.svelte is dynamically imported in most places, except in the +page.svelte route for maps
  • asset-viewer.svelte on individual-shared-viewer.svelte
  • asset-viewer.svelte on gallery-viewer.svelte

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/23217 **Author:** [@midzelis](https://github.com/midzelis) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/27/2025 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/imcomplete_dynamic_imports` --- ### 📝 Commits (1) - [`7b1c91f`](https://github.com/immich-app/immich/commit/7b1c91ff089c9d0adf409ed018b45445e4e6f580) fix: incomplete dynamic imports ### 📊 Changes **8 files changed** (+69 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/asset-viewer/detail-panel.svelte` (+4 -4) 📝 `web/src/lib/components/share-page/individual-shared-viewer.svelte` (+11 -10) 📝 `web/src/lib/components/shared-components/change-location.svelte` (+1 -1) 📝 `web/src/lib/components/shared-components/gallery-viewer/gallery-viewer.svelte` (+13 -12) 📝 `web/src/lib/components/shared-components/map/map.svelte` (+23 -14) 📝 `web/src/lib/components/timeline/TimelineAssetViewer.svelte` (+1 -1) 📝 `web/src/lib/modals/MapModal.svelte` (+1 -1) 📝 `web/src/routes/(user)/map/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+15 -6) </details> ### 📄 Description For dynamic imports to work as intended, EVERY usage of a candidate dynamic import component must be dynamically imported. The current dynamically imported components in Immich are: - map.svelte - asset-viewer.svelte - photo-sphere-viewer-adapter.svelte This PR fixes: - map.svelte is dynamically imported in most places, except in the +page.svelte route for maps - asset-viewer.svelte on individual-shared-viewer.svelte - asset-viewer.svelte on gallery-viewer.svelte --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:22:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?