immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 17 Packages Projects Releases 10 Wiki Activity

[BUG] Feature photos for people are changing after updating to 1.90.0 #1740

New Issue
Closed
opened 2026-02-05 03:25:51 +03:00 by OVERLORD · 16 comments
OVERLORD commented 2026-02-05 03:25:51 +03:00
Owner
Copy Link

Originally created by @eygraber on GitHub (Dec 8, 2023).

The bug

The feature photos that I set for people are no longer there. Instead there is a different photo from that person being used. It's not for all people, and it didn't seem to happen right after updating, but only after using the website for a little bit.

The OS that Immich Server is running on

Ubuntu 22.04

Version of Immich Server

v1.90.0

Version of Immich Mobile App

v1.90.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

version: "3.8"

services:
  immich-server:
    user: 1000:1001
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    command: [ "start.sh", "immich" ]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
    env_file:
      - .env
    ports:
      - "2283:3001"
    depends_on:
      - redis
      - database
      - typesense
    restart: always

  immich-microservices:
    user: 1000:1001
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends:
    #   file: hwaccel.yml
    #   service: hwaccel
    command: [ "start.sh", "microservices" ]
    volumes:
      - /disks/storage/immich/volumes/geocoding:/usr/src/app/.reverse-geocoding-dump
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
    env_file:
      - .env
    depends_on:
      - redis
      - database
      - typesense
    restart: always

  immich-machine-learning:
    user: 1000:1001
    container_name: immich_machine_learning
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    volumes:
      - /disks/storage/immich/volumes/model-cache:/cache
    env_file:
      - .env
    restart: always

  typesense:
    container_name: immich_typesense
    image: typesense/typesense:0.24.1@sha256:9bcff2b829f12074426ca044b56160ca9d777a0c488303469143dd9f8259d4dd
    environment:
      - TYPESENSE_API_KEY=${TYPESENSE_API_KEY}
      - TYPESENSE_DATA_DIR=/data
      # remove this to get debug messages
      - GLOG_minloglevel=1
    volumes:
      - /disks/storage/immich/volumes/tsdata:/data
    restart: always

  redis:
    container_name: immich_redis
    image: redis:6.2-alpine@sha256:70a7a5b641117670beae0d80658430853896b5ef269ccf00d1827427e3263fa3
    restart: always

  database:
    user: 1000:1001
    container_name: immich_postgres
    image: postgres:14-alpine@sha256:28407a9961e76f2d285dc6991e8e48893503cc3836a4755bbc2d40bcc272a441
    env_file:
      - .env
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
    volumes:
      - /disks/storage/immich/volumes/pgdata:/var/lib/postgresql/data
    restart: always

Your .env content

# You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables

PUID=1000
GUID=1001

# The location where your uploaded files are stored
UPLOAD_LOCATION=/disks/storage/immich/library

# The Immich version to use. You can pin this to a specific version like "v1.71.0"
IMMICH_VERSION=release

# Connection secrets for postgres and typesense. You should change these to random passwords
TYPESENSE_API_KEY=...
DB_PASSWORD=...

TZ=America/New_York

# The values below this line do not need to be changed
###################################################################################
DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_DATABASE_NAME=immich

REDIS_HOSTNAME=immich_redis

Reproduction steps

Not fully sure, just noticed that the feature photo changed for some people.

Additional information

No response

Originally created by @eygraber on GitHub (Dec 8, 2023). ### The bug The feature photos that I set for people are no longer there. Instead there is a different photo from that person being used. It's not for all people, and it didn't seem to happen right after updating, but only after using the website for a little bit. ### The OS that Immich Server is running on Ubuntu 22.04 ### Version of Immich Server v1.90.0 ### Version of Immich Mobile App v1.90.0 ### Platform with the issue - [X] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML version: "3.8" services: immich-server: user: 1000:1001 container_name: immich_server image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release} command: [ "start.sh", "immich" ] volumes: - ${UPLOAD_LOCATION}:/usr/src/app/upload env_file: - .env ports: - "2283:3001" depends_on: - redis - database - typesense restart: always immich-microservices: user: 1000:1001 container_name: immich_microservices image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release} # extends: # file: hwaccel.yml # service: hwaccel command: [ "start.sh", "microservices" ] volumes: - /disks/storage/immich/volumes/geocoding:/usr/src/app/.reverse-geocoding-dump - ${UPLOAD_LOCATION}:/usr/src/app/upload env_file: - .env depends_on: - redis - database - typesense restart: always immich-machine-learning: user: 1000:1001 container_name: immich_machine_learning image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release} volumes: - /disks/storage/immich/volumes/model-cache:/cache env_file: - .env restart: always typesense: container_name: immich_typesense image: typesense/typesense:0.24.1@sha256:9bcff2b829f12074426ca044b56160ca9d777a0c488303469143dd9f8259d4dd environment: - TYPESENSE_API_KEY=${TYPESENSE_API_KEY} - TYPESENSE_DATA_DIR=/data # remove this to get debug messages - GLOG_minloglevel=1 volumes: - /disks/storage/immich/volumes/tsdata:/data restart: always redis: container_name: immich_redis image: redis:6.2-alpine@sha256:70a7a5b641117670beae0d80658430853896b5ef269ccf00d1827427e3263fa3 restart: always database: user: 1000:1001 container_name: immich_postgres image: postgres:14-alpine@sha256:28407a9961e76f2d285dc6991e8e48893503cc3836a4755bbc2d40bcc272a441 env_file: - .env environment: POSTGRES_PASSWORD: ${DB_PASSWORD} POSTGRES_USER: ${DB_USERNAME} POSTGRES_DB: ${DB_DATABASE_NAME} volumes: - /disks/storage/immich/volumes/pgdata:/var/lib/postgresql/data restart: always ``` ### Your .env content ```Shell # You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables PUID=1000 GUID=1001 # The location where your uploaded files are stored UPLOAD_LOCATION=/disks/storage/immich/library # The Immich version to use. You can pin this to a specific version like "v1.71.0" IMMICH_VERSION=release # Connection secrets for postgres and typesense. You should change these to random passwords TYPESENSE_API_KEY=... DB_PASSWORD=... TZ=America/New_York # The values below this line do not need to be changed ################################################################################### DB_HOSTNAME=immich_postgres DB_USERNAME=postgres DB_DATABASE_NAME=immich REDIS_HOSTNAME=immich_redis ``` ### Reproduction steps ```bash Not fully sure, just noticed that the feature photo changed for some people. ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 03:26:03 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Dec 8, 2023):

Did you re-assign faces ?

@martabal commented on GitHub (Dec 8, 2023): Did you re-assign faces ?
OVERLORD commented 2026-02-05 03:26:10 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 8, 2023):

I did with one of them, but I'm not 100% sure of the other (although given the circumstances I probably did)

@eygraber commented on GitHub (Dec 8, 2023): I did with one of them, but I'm not 100% sure of the other (although given the circumstances I probably did)
OVERLORD commented 2026-02-05 03:26:13 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Dec 8, 2023):

If you re-assigned the face which is the feature photo of the edited person, yes it's supposed to change the feature photo. You don't want two people having the same feature photo

@martabal commented on GitHub (Dec 8, 2023): If you re-assigned the face which is the feature photo of the edited person, yes it's supposed to change the feature photo. You don't want two people having the same feature photo
OVERLORD commented 2026-02-05 03:26:16 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 8, 2023):

I'm not sure I understand. This is what happened

  1. Person A was tagged in a photo they were not in
  2. I reassigned the face in that photo to Person B
  3. Person B's feature photo changed
@eygraber commented on GitHub (Dec 8, 2023): I'm not sure I understand. This is what happened 1. Person A was tagged in a photo they were not in 2. I reassigned the face in that photo to Person B 3. Person B's feature photo changed
OVERLORD commented 2026-02-05 03:26:18 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Dec 8, 2023):

It means the Person B faceAssetId was set to null 🤔 When was that person created ? If it was a long time ago, I think one release mentioned to re-generate the feature photos to avoid this issue.

@martabal commented on GitHub (Dec 8, 2023): It means the Person B `faceAssetId` was set to null :thinking: When was that person created ? If it was a long time ago, I think one release mentioned to re-generate the feature photos to avoid this issue.
OVERLORD commented 2026-02-05 03:26:21 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 8, 2023):

Person B was probably created a couple of months ago. I searched the release notes for "feature photo" and only found two mentions; when the ability to change them was added and something related to websockets. I'd appreciate any more info if someone has 🙏

@eygraber commented on GitHub (Dec 8, 2023): Person B was probably created a couple of months ago. I searched the release notes for "feature photo" and only found two mentions; when the ability to change them was added and something related to websockets. I'd appreciate any more info if someone has :pray:
OVERLORD commented 2026-02-05 03:26:24 +03:00
Author
Owner
Copy Link

@raisinbear commented on GitHub (Dec 8, 2023):

Yeah I noticed the same with following scenario: person wrongfully identified as person „A“, when reassigned to person „B“, the feature photo for „B“ changes to a presumably random one. This process did not alter the feature photo for person „A“ and was not the feature photo for person „A“. Could reproduce this multiple times. Hope this helps!
Awesome feature by the way! Thanks so much for the effort @martabal ! 🤩

Edit: Should have read more carefully. The feature photos of the persons in question were set around August. So yeah could be that I missed the release notes saying to re-generate feature photos or plainly ignored that recommendation. Sadly I wasn't able to find it anymore either. I definitely re-ran the generate thumbnails job at some point, though, if that's what it's about. I think that was when the directory layout was changed to subfolders for thumbs.

@raisinbear commented on GitHub (Dec 8, 2023): Yeah I noticed the same with following scenario: person wrongfully identified as person „A“, when reassigned to person „B“, the feature photo for „B“ changes to a presumably random one. This process did not alter the feature photo for person „A“ and was not the feature photo for person „A“. Could reproduce this multiple times. Hope this helps! Awesome feature by the way! Thanks so much for the effort @martabal ! 🤩 Edit: Should have read more carefully. The feature photos of the persons in question were set around August. So yeah could be that I missed the release notes saying to re-generate feature photos or plainly ignored that recommendation. Sadly I wasn't able to find it anymore either. I definitely re-ran the generate thumbnails job at some point, though, if that's what it's about. I think that was when the directory layout was changed to subfolders for thumbs.
OVERLORD commented 2026-02-05 03:26:27 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 10, 2023):

@martabal sorry if I misunderstood, but is there anything we can do to prevent this from happening?

@eygraber commented on GitHub (Dec 10, 2023): @martabal sorry if I misunderstood, but is there anything we can do to prevent this from happening?
OVERLORD commented 2026-02-05 03:26:28 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Dec 10, 2023):

We used to set a feature photo and not track what asset it came from. With the recent changes a feature photo has to have a reference back to the asset it came from, otherwise we'll lose it and pick a random one. This is just a problem with how the implementation was originally built and it should not happen on a regular basis.

@jrasm91 commented on GitHub (Dec 10, 2023): We used to set a feature photo and not track what asset it came from. With the recent changes a feature photo _has_ to have a reference back to the asset it came from, otherwise we'll lose it and pick a random one. This is just a problem with how the implementation was originally built and it should not happen on a regular basis.
OVERLORD commented 2026-02-05 03:26:30 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 10, 2023):

Anything I can do to prevent it from happening further, or I just have to deal with it as it happens?

@eygraber commented on GitHub (Dec 10, 2023): Anything I can do to prevent it from happening further, or I just have to deal with it as it happens?
OVERLORD commented 2026-02-05 03:26:33 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Dec 10, 2023):

You can set the feature photo with the "Change feature" option on the person page, it will fix the issue. But there's no easy way to know which person has their faceAssetId set to null, you'll have to check in the database yourself

@martabal commented on GitHub (Dec 10, 2023): You can set the feature photo with the "Change feature" option on the person page, it will fix the issue. But there's no easy way to know which person has their `faceAssetId` set to null, you'll have to check in the database yourself
OVERLORD commented 2026-02-05 03:26:37 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 10, 2023):

Got it thanks! Seems like this could be closed then?

@eygraber commented on GitHub (Dec 10, 2023): Got it thanks! Seems like this could be closed then?
OVERLORD commented 2026-02-05 03:26:42 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 21, 2023):

This is still happening on v1.91.4 for people that shouldn't have faceAssetId == null (i.e. I've already set their feature photo recently).

It seems to happen after reassigning a face to that person; is this something that https://github.com/immich-app/immich/pull/5796 addresses, or is there something else going on?

@eygraber commented on GitHub (Dec 21, 2023): This is still happening on v1.91.4 for people that shouldn't have `faceAssetId == null` (i.e. I've already set their feature photo recently). It seems to happen after reassigning a face to that person; is this something that https://github.com/immich-app/immich/pull/5796 addresses, or is there something else going on?
OVERLORD commented 2026-02-05 03:26:47 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Dec 21, 2023):

This has nothing to do with this.

Can you make sure you don't have people with faceAssetId set to null with SELECT * FROM "person" WHERE "faceAssetId" IS NULL

@martabal commented on GitHub (Dec 21, 2023): This has nothing to do with this. Can you make sure you don't have people with faceAssetId set to null with `SELECT * FROM "person" WHERE "faceAssetId" IS NULL`
OVERLORD commented 2026-02-05 03:26:53 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 21, 2023):

I checked and I have 86 with faceAssetId != null and 255 with faceAssetId == null (this is only for people that have a name; there's 12k more that don't have a name).

For the ones that are null, I've definitely set a feature photo for them recently.

@eygraber commented on GitHub (Dec 21, 2023): I checked and I have 86 with `faceAssetId != null` and 255 with `faceAssetId == null` (this is only for people that have a name; there's 12k more that don't have a name). For the ones that are null, I've definitely set a feature photo for them recently.
OVERLORD commented 2026-02-05 03:26:57 +03:00
Author
Owner
Copy Link

@eygraber commented on GitHub (Dec 25, 2023):

Also finding that some newly created people have a null faceAssetId. Can this be re-opened, or should I file a new issue?

@eygraber commented on GitHub (Dec 25, 2023): Also finding that some newly created people have a null `faceAssetId`. Can this be re-opened, or should I file a new issue?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1740
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?