immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #22978] [MERGED] fix: Show correct photo name in buttom sheet and backup details page #17397

New Issue
Closed
opened 2026-02-05 16:21:09 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:21:09 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/22978
Author: @FawenYo
Created: 10/16/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @alextran1502

Base: fix/fetch-origin-name ← Head: fix/fetch-origin-name-more-fixes

📝 Commits (1)

  • 51836ba fix: Show correct name in buttom sheet and backup details page

📊 Changes

2 files changed (+95 additions, -57 deletions)

View changed files

📝 mobile/lib/pages/backup/drift_backup_asset_detail.page.dart (+52 -44)
📝 mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart (+43 -13)

📄 Description

Description

This is a follow-up PR to https://github.com/immich-app/immich/pull/21877. The goal is to use the same approach to fix an issue where the file names of some assets in the photo bottom sheet and backup details pages are displayed in UUID format instead of the correct file name.

Fixes https://github.com/immich-app/immich/issues/20630

How Has This Been Tested?

I've tried to compile the app and installed it on my iPhone, and all photos display the correct name now

Before After
Image Image

Screenshots (if appropriate)

Image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

mobile/lib/pages/backup/drift_backup_asset_detail.page.dart was manually written, and mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart was processed by an LLM following the same modification approach. I believe the changes made are reasonable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/22978 **Author:** [@FawenYo](https://github.com/FawenYo) **Created:** 10/16/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `fix/fetch-origin-name` ← **Head:** `fix/fetch-origin-name-more-fixes` --- ### 📝 Commits (1) - [`51836ba`](https://github.com/immich-app/immich/commit/51836bae94edc866218d559a5f2068c47e67e5e1) fix: Show correct name in buttom sheet and backup details page ### 📊 Changes **2 files changed** (+95 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/pages/backup/drift_backup_asset_detail.page.dart` (+52 -44) 📝 `mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart` (+43 -13) </details> ### 📄 Description ## Description This is a follow-up PR to https://github.com/immich-app/immich/pull/21877. The goal is to use the same approach to fix an issue where the file names of some assets in the photo bottom sheet and backup details pages are displayed in UUID format instead of the correct file name. Fixes https://github.com/immich-app/immich/issues/20630 ## How Has This Been Tested? I've tried to compile the app and installed it on my iPhone, and all photos display the correct name now | Before | After | :-------------------------:|:-------------------------: ![Image](https://github.com/user-attachments/assets/3879e287-5cdc-44f1-99c0-9cc25c1aa829) | ![Image](https://github.com/user-attachments/assets/b385991f-dbd6-4be3-b828-e85e3ef3a275) <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> ![Image](https://github.com/user-attachments/assets/b385991f-dbd6-4be3-b828-e85e3ef3a275) </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. `mobile/lib/pages/backup/drift_backup_asset_detail.page.dart` was manually written, and `mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart` was processed by an LLM following the same modification approach. I believe the changes made are reasonable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:21:09 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17397
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?