immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #22372] [MERGED] fix(pump-version): fix immich-ml pyproject.toml path #17200

New Issue
Closed
opened 2026-02-05 16:17:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:17:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/22372
Author: @aaronliu0130
Created: 9/25/2025
Status: ✅ Merged
Merged: 9/25/2025
Merged by: @mertalev

Base: main ← Head: main

📝 Commits (1)

  • a278a65 fix(pump-version): fix immich-ml pyproject.toml path

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 machine-learning/pyproject.toml (+1 -1)
📝 misc/release/pump-version.sh (+1 -1)

📄 Description

Description

Since the migration to uv, this has not worked because the Python toml CLI has been looking for a pyproject.toml in the root folder.

How Has This Been Tested?

  • Tried the new command uvx...

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
    • I'm fairly sure bumping the immich-ml version to 1.143.1 is a related change.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

washing the dishes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/22372 **Author:** [@aaronliu0130](https://github.com/aaronliu0130) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 9/25/2025 **Merged by:** [@mertalev](https://github.com/mertalev) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`a278a65`](https://github.com/immich-app/immich/commit/a278a651423789a272629e6a49c6eb38f64b234a) fix(pump-version): fix immich-ml pyproject.toml path ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `machine-learning/pyproject.toml` (+1 -1) 📝 `misc/release/pump-version.sh` (+1 -1) </details> ### 📄 Description ## Description Since the migration to uv, this has not worked because the Python toml CLI has been looking for a pyproject.toml in the root folder. ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] Tried the new command `uvx...` ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - - I'm fairly sure bumping the immich-ml version to 1.143.1 is a related change. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. washing the dishes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:17:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17200
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?