immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #22274] [MERGED] feat(web): reactively update shared link expiration #17166

New Issue
Closed
opened 2026-02-05 16:17:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:17:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/22274
Author: @khanbasharat3a1
Created: 9/21/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @danieldietzler

Base: main ← Head: main

📝 Commits (3)

  • 6aab255 fix(web): update shared link expiration in UI without full refresh
  • c6db1fe Merge pull request #1 from khanbasharat3a1/fix-shared-link-expiration-display
  • 9d62c8b Merge branch 'main' into main

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 web/src/lib/modals/SharedLinkCreateModal.svelte (+2 -2)
📝 web/src/routes/(user)/shared-links/[[id=id]]/+page.svelte (+9 -2)

📄 Description

Description

fix(web): update shared link expiration in UI without full refresh

This commit fixes a UI bug where the expiration date of a shared link was not updating correctly after being edited.

The SharedLinkCreateModal is modified to return the updated shared link data upon successful edit. The parent page now uses this data to update its local state directly, avoiding a full page refresh and providing a better user experience.

Fixes # (issue)

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/22274 **Author:** [@khanbasharat3a1](https://github.com/khanbasharat3a1) **Created:** 9/21/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@danieldietzler](https://github.com/danieldietzler) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`6aab255`](https://github.com/immich-app/immich/commit/6aab255096ce49342e10bc7f96485d6ce6e3e97b) fix(web): update shared link expiration in UI without full refresh - [`c6db1fe`](https://github.com/immich-app/immich/commit/c6db1fe0fe3ed5aac802c85744885ae4fb2591c5) Merge pull request #1 from khanbasharat3a1/fix-shared-link-expiration-display - [`9d62c8b`](https://github.com/immich-app/immich/commit/9d62c8be5de6718c948dda89999fdde72e6065c5) Merge branch 'main' into main ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/modals/SharedLinkCreateModal.svelte` (+2 -2) 📝 `web/src/routes/(user)/shared-links/[[id=id]]/+page.svelte` (+9 -2) </details> ### 📄 Description ## Description fix(web): update shared link expiration in UI without full refresh This commit fixes a UI bug where the expiration date of a shared link was not updating correctly after being edited. The `SharedLinkCreateModal` is modified to return the updated shared link data upon successful edit. The parent page now uses this data to update its local state directly, avoiding a full page refresh and providing a better user experience. Fixes # (issue) ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] Test A - [x] Test B <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. ... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:17:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?