immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #22070] [CLOSED] refactor: Finish timeline migration - remove AssetGrid #17080

New Issue
Closed
opened 2026-02-05 16:15:35 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:15:35 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/22070
Author: @midzelis
Created: 9/16/2025
Status: ❌ Closed

Base: refactor/timeline2 ← Head: refactor/timeline3

📝 Commits (1)

  • 1f66bb8 refactor: Finish timeline migration by removing AssetGrid wrapper

📊 Changes

12 files changed (+36 additions, -148 deletions)

View changed files

📝 web/src/lib/components/album-page/album-viewer.svelte (+3 -3)
➖ web/src/lib/components/photos-page/asset-grid.svelte (+0 -102)
📝 web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/archive/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/favorites/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/locked/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/partners/[userId]/[[photos=photos]]/[[assetId=id]]/+page.svelte (+2 -2)
📝 web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/photos/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/tags/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/trash/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -3)
📝 web/src/routes/(user)/utilities/geolocation/+page.svelte (+7 -17)

📄 Description

  • Remove AssetGrid wrapper
  • Update all remaining route files to import Timeline directly
  • Fix component signatures where needed (onThumbnailClick → onAssetOpen)
  • Update album-viewer component to use Timeline
  • Update geolocation route with proper callback signature

All routes and album-viewer component now use Timeline component directly

The major parts of the refactoring are complete.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/22070 **Author:** [@midzelis](https://github.com/midzelis) **Created:** 9/16/2025 **Status:** ❌ Closed **Base:** `refactor/timeline2` ← **Head:** `refactor/timeline3` --- ### 📝 Commits (1) - [`1f66bb8`](https://github.com/immich-app/immich/commit/1f66bb8fdc875d8b8faafaf1ee34462bb15173e9) refactor: Finish timeline migration by removing AssetGrid wrapper ### 📊 Changes **12 files changed** (+36 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/album-page/album-viewer.svelte` (+3 -3) ➖ `web/src/lib/components/photos-page/asset-grid.svelte` (+0 -102) 📝 `web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/archive/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/favorites/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/locked/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/partners/[userId]/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+2 -2) 📝 `web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/photos/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/tags/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/trash/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -3) 📝 `web/src/routes/(user)/utilities/geolocation/+page.svelte` (+7 -17) </details> ### 📄 Description - Remove AssetGrid wrapper - Update all remaining route files to import Timeline directly - Fix component signatures where needed (onThumbnailClick → onAssetOpen) - Update album-viewer component to use Timeline - Update geolocation route with proper callback signature All routes and album-viewer component now use Timeline component directly The major parts of the refactoring are complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:15:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#17080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?