immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #21641] feat(mobile): make hashed asset count reactive #16914

New Issue
Closed
opened 2026-02-05 16:12:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:12:54 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/21641

State: closed
Merged: No

Description

This change enables the hashed assets count in the Beta Sync Status to react to database updates, removing the need to leave/reopen the page.

Fixes #21434, #21447

Open points

With large hashing batches (currently 256 assets or 1 GB), the visible count can stay flat for a while because most time is spent downloading before DB updates occur. From a UX point of view, I would suggest either lowering the limits defined in the constants file (e.g., 32 assets, 128 MB) or implementing sub-flushes in the batch processing, so that the counter updates more frequently.

How Has This Been Tested?

  • Environment: iPhone 15 Pro, iOS 26.
  • Automated tests.
  • Manual:
    • Started a local hashing job both from a fresh app install and from an already started app with hashed assets; observed the “Hashed assets” count increment automatically without reopening the page.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)
**Original Pull Request:** https://github.com/immich-app/immich/pull/21641 **State:** closed **Merged:** No --- ## Description This change enables the hashed assets count in the Beta Sync Status to react to database updates, removing the need to leave/reopen the page. Fixes #21434, #21447 ### Open points With large hashing batches (currently 256 assets or 1 GB), the visible count can stay flat for a while because most time is spent downloading before DB updates occur. From a UX point of view, I would suggest either lowering the limits defined in the constants file (e.g., 32 assets, 128 MB) or implementing sub-flushes in the batch processing, so that the counter updates more frequently. ## How Has This Been Tested? - Environment: iPhone 15 Pro, iOS 26. - Automated tests. - Manual: - Started a local hashing job both from a fresh app install and from an already started app with hashed assets; observed the “Hashed assets” count increment automatically without reopening the page. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
OVERLORD added the pull-request label 2026-02-05 16:12:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#16914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?