immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #21094] feat(web): use timeline in geolocation manager #16746

New Issue
Closed
opened 2026-02-05 16:10:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:10:10 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/21094

State: closed
Merged: No

Description

Use timeline instead of custom grid to manage geolocation in utilities.

To do :

  • update bucket, since we need locations from /api/timeline/bucket?timeBucket
  • remove dead code from previous PR : datepicker, url setter, unit test
  • discuss the design choice as I had to pass callback through asset-grid and asset-date-group files
  • ensure there is no regression since asset-date-group have been updated

To implement : Filter by assetWithoutLocation, we have to add specific property in bucketDto, and repository. Not sure it is worth it.

See comment here : https://github.com/immich-app/immich/pull/20758#issuecomment-3201266518
Timeline would be better to manage geolocation

Code update highlights

Add property and method to AssetGrid and AssetDateGroup :

  • customLayout
  • onThumbnailClick

How Has This Been Tested?

  • Manual test

Screenshots (if appropriate)

output (1)

**Original Pull Request:** https://github.com/immich-app/immich/pull/21094 **State:** closed **Merged:** No --- ## Description <!--- Describe your changes in detail --> Use timeline instead of custom grid to manage geolocation in utilities. To do : - [x] update bucket, since we need locations from /api/timeline/bucket?timeBucket - [x] remove dead code from previous PR : datepicker, url setter, unit test - [ ] discuss the design choice as I had to pass callback through asset-grid and asset-date-group files - [x] ensure there is no regression since asset-date-group have been updated To implement : Filter by assetWithoutLocation, we have to add specific property in bucketDto, and repository. Not sure it is worth it. <!--- Why is this change required? What problem does it solve? --> See comment here : https://github.com/immich-app/immich/pull/20758#issuecomment-3201266518 Timeline would be better to manage geolocation ### Code update highlights Add property and method to AssetGrid and AssetDateGroup : - customLayout - onThumbnailClick <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] Manual test <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> ![output (1)](https://github.com/user-attachments/assets/aeba05f9-61cd-4a34-a9c4-5f06cd94409e) </details> <!-- API endpoint changes (if relevant) ## API Changes - [ ] Changes required of endpoint: /api/timeline/bucket?timeBucket ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [ ] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
OVERLORD added the pull-request label 2026-02-05 16:10:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#16746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?