immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #20666] feat(mobile): use custom headers when connecting in widget #16628

New Issue
Closed
opened 2026-02-05 16:08:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:08:13 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/20666

State: closed
Merged: Yes

Description

The widget previously did not use the custom headers set by app. This caused authentication errors to occur if users were using headers to bypass auth providers like Cloudflare Zero Trust.

Fixes #20452

How Has This Been Tested?

Tested on both iOS and android widgets. Headers are properly loaded on both platforms and headers are applied to the request objects. I do not have an easy way of dumping headers from the server but the headers are applied in an identical way to the Content-Type field we use for the search API.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)
**Original Pull Request:** https://github.com/immich-app/immich/pull/20666 **State:** closed **Merged:** Yes --- ## Description The widget previously did not use the custom headers set by app. This caused authentication errors to occur if users were using headers to bypass auth providers like Cloudflare Zero Trust. Fixes #20452 ## How Has This Been Tested? Tested on both iOS and android widgets. Headers are properly loaded on both platforms and headers are applied to the request objects. I do not have an easy way of dumping headers from the server but the headers are applied in an identical way to the Content-Type field we use for the search API. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
OVERLORD added the pull-request label 2026-02-05 16:08:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#16628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?