immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 14 Packages Projects Releases 10 Wiki Activity

[BUG] Partner Sharing - Unable to delete photo #1661

New Issue
Closed
opened 2026-02-05 02:55:32 +03:00 by OVERLORD · 8 comments
OVERLORD commented 2026-02-05 02:55:32 +03:00
Owner
Copy Link

Originally created by @yurividal on GitHub (Nov 21, 2023).

The bug

When partner sharing on the time-line is enabled, the user who doesn't own the picture cannot delete a shared picture. The delete button does nothing.
If this is by design, then the button needs to be hidden, or some sort of UI element to tell the user he can't delete partner's photos.
Even better would be if there was an option in the settings to allow a user to do such a thing.

The OS that Immich Server is running on

Ubuntu 22.04

Version of Immich Server

V1.88.1

Version of Immich Mobile App

V1.88.1

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

Same as example one.

Your .env content

Same as example one

Reproduction steps

1. Enable partner sharing
2. Enable shared photos on timeline
3. Try to delete a photo that belongs to your partner. Mobile and Web
...

Additional information

No response

Originally created by @yurividal on GitHub (Nov 21, 2023). ### The bug When partner sharing on the time-line is enabled, the user who doesn't own the picture cannot delete a shared picture. The delete button does nothing. If this is by design, then the button needs to be hidden, or some sort of UI element to tell the user he can't delete partner's photos. Even better would be if there was an option in the settings to allow a user to do such a thing. ### The OS that Immich Server is running on Ubuntu 22.04 ### Version of Immich Server V1.88.1 ### Version of Immich Mobile App V1.88.1 ### Platform with the issue - [X] Server - [X] Web - [X] Mobile ### Your docker-compose.yml content ```YAML Same as example one. ``` ### Your .env content ```Shell Same as example one ``` ### Reproduction steps ```bash 1. Enable partner sharing 2. Enable shared photos on timeline 3. Try to delete a photo that belongs to your partner. Mobile and Web ... ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 02:55:37 +03:00
Author
Owner
Copy Link

@BarrettLowe commented on GitHub (Dec 2, 2023):

Looks like the following may be the culprit:
8a2b36ad55/web/src/lib/components/photos-page/actions/delete-assets.svelte (L40)

I don't know typescript so I'm having a hard time tracking this backward but at an initial glance, it may work to change this to use getAssets instead...?

@BarrettLowe commented on GitHub (Dec 2, 2023): Looks like the following may be the culprit: https://github.com/immich-app/immich/blob/8a2b36ad55169a6befe4a23bfac8e4f8b697af43/web/src/lib/components/photos-page/actions/delete-assets.svelte#L40 I don't know typescript so I'm having a hard time tracking this backward but at an initial glance, it may work to change this to use getAssets instead...?
OVERLORD commented 2026-02-05 02:55:42 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Dec 2, 2023):

This is as designed. Let me think of a way to make it less confused

@alextran1502 commented on GitHub (Dec 2, 2023): This is as designed. Let me think of a way to make it less confused
OVERLORD commented 2026-02-05 02:55:52 +03:00
Author
Owner
Copy Link

@yurividal commented on GitHub (Dec 3, 2023):

This is as designed. Let me think of a way to make it less confused

Thought it would be as design. Indeed a UI hint is needed here.

Even better would be if there was a option to allow deletion of partners photos.

(Example: my wife is constantly taking pictures of receipts or things she only needs for a few minutes, and never remembers to delete them from immich. I'd love to be able to clean these every now and then, instead of filling our precious storage space with useless pictures)

@yurividal commented on GitHub (Dec 3, 2023): > This is as designed. Let me think of a way to make it less confused Thought it would be as design. Indeed a UI hint is needed here. Even better would be if there was a option to allow deletion of partners photos. (Example: my wife is constantly taking pictures of receipts or things she only needs for a few minutes, and never remembers to delete them from immich. I'd love to be able to clean these every now and then, instead of filling our precious storage space with useless pictures)
OVERLORD commented 2026-02-05 02:55:58 +03:00
Author
Owner
Copy Link

@Fl0ete commented on GitHub (Jan 4, 2024):

This is as designed. Let me think of a way to make it less confused

Thought it would be as design. Indeed a UI hint is needed here.

Even better would be if there was a option to allow deletion of partners photos.

(Example: my wife is constantly taking pictures of receipts or things she only needs for a few minutes, and never remembers to delete them from immich. I'd love to be able to clean these every now and then, instead of filling our precious storage space with useless pictures)

I'd also love to see this. In my case, I am always the one "thinning out" the photos, deleteing blurred ones, keeping only the best shot of many of the same motive. And I would love to just show my partners photos in my timeline (especially with kids), but having them raw is not really satisfying.

Kind of a big ask, but for me the optimal solution would be something like this: I mark the pictures for deletion and my partner gets a notification/hint to look over them and confirm. This way, she doesn't have the work and can still be sure I delete nothing important to her.

@Fl0ete commented on GitHub (Jan 4, 2024): > > This is as designed. Let me think of a way to make it less confused > > Thought it would be as design. Indeed a UI hint is needed here. > > Even better would be if there was a option to allow deletion of partners photos. > > (Example: my wife is constantly taking pictures of receipts or things she only needs for a few minutes, and never remembers to delete them from immich. I'd love to be able to clean these every now and then, instead of filling our precious storage space with useless pictures) I'd also love to see this. In my case, I am always the one "thinning out" the photos, deleteing blurred ones, keeping only the best shot of many of the same motive. And I would love to just show my partners photos in my timeline (especially with kids), but having them raw is not really satisfying. Kind of a big ask, but for me the optimal solution would be something like this: I mark the pictures for deletion and my partner gets a notification/hint to look over them and confirm. This way, she doesn't have the work and can still be sure I delete nothing important to her.
OVERLORD commented 2026-02-05 02:56:08 +03:00
Author
Owner
Copy Link

@Jab2870 commented on GitHub (Mar 25, 2024):

I'm not sure if this is really the correct place to ask, but I would really like to see the partner sharing to allow a lot more control.

Deleting photos is certainly part of that, but other stuff like being able to add a partner's photos to an album etc.

@Jab2870 commented on GitHub (Mar 25, 2024): I'm not sure if this is really the correct place to ask, but I would really like to see the partner sharing to allow a lot more control. Deleting photos is certainly part of that, but other stuff like being able to add a partner's photos to an album etc.
OVERLORD commented 2026-02-05 02:56:10 +03:00
Author
Owner
Copy Link

@andrewdcaudle commented on GitHub (Apr 10, 2024):

I concur with a setting that would allow partners to delete the other's images.

@andrewdcaudle commented on GitHub (Apr 10, 2024): I concur with a setting that would allow partners to delete the other's images.
OVERLORD commented 2026-02-05 02:56:12 +03:00
Author
Owner
Copy Link

@Tonylolo commented on GitHub (Apr 10, 2024):

Yes , very good idea, partner would become a real user. 2 users of 1 photo server, a lot of case for family i think.
Thk for taking in consideration

@Tonylolo commented on GitHub (Apr 10, 2024): Yes , very good idea, partner would become a real user. 2 users of 1 photo server, a lot of case for family i think. Thk for taking in consideration
OVERLORD commented 2026-02-05 02:56:16 +03:00
Author
Owner
Copy Link

@krin-san commented on GitHub (Apr 19, 2024):

I concur with a setting that would allow partners to delete the other's images.

I actually tried to find if this option exists on /user-settings?isOpen=partner-sharing page. Imagined, it could look like that:

Screen Shot 2024-04-19 at 00 01 47

@krin-san commented on GitHub (Apr 19, 2024): > I concur with a setting that would allow partners to delete the other's images. I actually tried to find if this option exists on `/user-settings?isOpen=partner-sharing` page. Imagined, it could look like that: ![Screen Shot 2024-04-19 at 00 01 47](https://github.com/immich-app/immich/assets/2318002/c83d7a2e-9864-435f-a043-ec10d65657f8)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1661
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?