immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #18985] feat(server): Add album filter to search #15907

New Issue
Closed
opened 2026-02-05 15:56:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:56:27 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/18985

State: closed
Merged: Yes

Description

Adds an album filter to the search repository's searchAssetBuilder. The filter's albumIds behave like OR (photos within any of the selected albums). When albums are supplied, the isNotInAlbum filter is skipped.
Updated smart, metadata, and random search dtos, and applied open-api updates for dart & web dtos.

I have the web part built and will submit a separate PR once this is merged.

How Has This Been Tested?

Added the web front end to test search. Selecting albums from the albums search filter reduces search results to only those included in the albums

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)
**Original Pull Request:** https://github.com/immich-app/immich/pull/18985 **State:** closed **Merged:** Yes --- ## Description Adds an album filter to the search repository's searchAssetBuilder. The filter's albumIds behave like OR (photos within any of the selected albums). When albums are supplied, the isNotInAlbum filter is skipped. Updated smart, metadata, and random search dtos, and applied open-api updates for dart & web dtos. I have the web part built and will submit a separate PR once this is merged. ## How Has This Been Tested? Added the web front end to test search. Selecting albums from the albums search filter reduces search results to only those included in the albums ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
OVERLORD added the pull-request label 2026-02-05 15:56:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#15907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?