immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #18107] chore: better modal manager types #15566

New Issue
Closed
opened 2026-02-05 15:50:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:50:54 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/18107

State: closed
Merged: Yes

The second argument (props) is now optional if the passed component (let's call it Foo) only exposes onClose. In this case, the following three calls are all valid:

  • modalManager.open(Foo);
  • modalManager.open(Foo, undefined);
  • modalManager.open(Foo, {});

A non-empty object such as in modalManager.open(Foo, { foo: '42' }) is now invalid.

**Original Pull Request:** https://github.com/immich-app/immich/pull/18107 **State:** closed **Merged:** Yes --- The second argument (`props`) is now optional if the passed component (let's call it `Foo`) only exposes `onClose`. In this case, the following three calls are all valid: - `modalManager.open(Foo)`; - `modalManager.open(Foo, undefined);` - `modalManager.open(Foo, {});` A non-empty object such as in `modalManager.open(Foo, { foo: '42' })` is now invalid.
OVERLORD added the pull-request label 2026-02-05 15:50:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#15566
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?