immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #16664] [MERGED] fix(web): add labels to memory lane buttons #14983

New Issue
Closed
opened 2026-02-05 15:41:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:41:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/16664
Author: @lukashass
Created: 3/6/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @alextran1502

Base: main ← Head: add-memory-lane-button-labels

📝 Commits (2)

  • 9c3e06e fix(web): add labels to memory lane buttons
  • 9bbfcd8 use generic button labels

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 web/src/lib/components/photos-page/memory-lane.svelte (+6 -2)

📄 Description

Description

Adds title and labels to memory lane scroll buttons.

How Has This Been Tested?

  • Manual test in Firefox

Screenshots (if appropriate)

image
image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/16664 **Author:** [@lukashass](https://github.com/lukashass) **Created:** 3/6/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `add-memory-lane-button-labels` --- ### 📝 Commits (2) - [`9c3e06e`](https://github.com/immich-app/immich/commit/9c3e06e8680fb6c7e533231056afd589cba4a1ae) fix(web): add labels to memory lane buttons - [`9bbfcd8`](https://github.com/immich-app/immich/commit/9bbfcd8ed6469ca342b143d6e49119ed21df0478) use generic button labels ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/photos-page/memory-lane.svelte` (+6 -2) </details> ### 📄 Description ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Adds title and labels to memory lane scroll buttons. ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] Manual test in Firefox <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> ![image](https://github.com/user-attachments/assets/77daae7a-46f4-4d00-bc70-46f0e747059b) ![image](https://github.com/user-attachments/assets/c33efaa5-4121-4230-aee2-14553430c856) </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [x] I have written tests for new code (if applicable) - [x] I have followed naming conventions/patterns in the surrounding code - [x] All code in `src/services` uses repositories implementations for database calls, filesystem operations, etc. - [x] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:41:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#14983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?