immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #15937] [MERGED] feat(api): set person color #14700

New Issue
Closed
opened 2026-02-05 15:36:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:36:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/15937
Author: @jrasm91
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @jrasm91

Base: main ← Head: feat/person-color

📝 Commits (1)

  • 24a4a5f feat(api): set person color

📊 Changes

18 files changed (+182 additions, -21 deletions)

View changed files

📝 e2e/src/api/specs/person.e2e-spec.ts (+19 -0)
📝 mobile/openapi/lib/model/people_update_item.dart (+12 -1)
📝 mobile/openapi/lib/model/person_create_dto.dart (+12 -1)
📝 mobile/openapi/lib/model/person_response_dto.dart (+19 -1)
📝 mobile/openapi/lib/model/person_update_dto.dart (+12 -1)
📝 mobile/openapi/lib/model/person_with_faces_response_dto.dart (+19 -1)
📝 open-api/immich-openapi-specs.json (+20 -1)
📝 open-api/typescript-sdk/src/fetch-client.ts (+7 -0)
📝 server/src/db.d.ts (+1 -0)
📝 server/src/dtos/person.dto.ts (+15 -1)
📝 server/src/dtos/tag.dto.ts (+3 -5)
📝 server/src/entities/person.entity.ts (+3 -0)
➕ server/src/migrations/1738889177573-AddPersonColor.ts (+14 -0)
📝 server/src/services/person.service.spec.ts (+2 -2)
📝 server/src/services/person.service.ts (+8 -4)
📝 server/src/services/search.service.spec.ts (+2 -0)
📝 server/src/services/search.service.ts (+4 -3)
📝 server/src/validation.ts (+10 -0)

📄 Description

This PR adds a color property to PersonEntity, which can be used to associate a hex color to a person. The purpose and plan for this property is to be used with something like #10469. After the API is available the web can be expanded to show a border around the face of the person, and also use this color in the "show face bounding box on hover" feature.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/15937 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `feat/person-color` --- ### 📝 Commits (1) - [`24a4a5f`](https://github.com/immich-app/immich/commit/24a4a5f49fae72007b26d80caeb7b8a474e8bb9b) feat(api): set person color ### 📊 Changes **18 files changed** (+182 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `e2e/src/api/specs/person.e2e-spec.ts` (+19 -0) 📝 `mobile/openapi/lib/model/people_update_item.dart` (+12 -1) 📝 `mobile/openapi/lib/model/person_create_dto.dart` (+12 -1) 📝 `mobile/openapi/lib/model/person_response_dto.dart` (+19 -1) 📝 `mobile/openapi/lib/model/person_update_dto.dart` (+12 -1) 📝 `mobile/openapi/lib/model/person_with_faces_response_dto.dart` (+19 -1) 📝 `open-api/immich-openapi-specs.json` (+20 -1) 📝 `open-api/typescript-sdk/src/fetch-client.ts` (+7 -0) 📝 `server/src/db.d.ts` (+1 -0) 📝 `server/src/dtos/person.dto.ts` (+15 -1) 📝 `server/src/dtos/tag.dto.ts` (+3 -5) 📝 `server/src/entities/person.entity.ts` (+3 -0) ➕ `server/src/migrations/1738889177573-AddPersonColor.ts` (+14 -0) 📝 `server/src/services/person.service.spec.ts` (+2 -2) 📝 `server/src/services/person.service.ts` (+8 -4) 📝 `server/src/services/search.service.spec.ts` (+2 -0) 📝 `server/src/services/search.service.ts` (+4 -3) 📝 `server/src/validation.ts` (+10 -0) </details> ### 📄 Description This PR adds a `color` property to `PersonEntity`, which can be used to associate a hex color to a person. The purpose and plan for this property is to be used with something like #10469. After the API is available the web can be expanded to show a border around the face of the person, and also use this color in the "show face bounding box on hover" feature. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:36:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#14700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?