immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 12 Packages Projects Releases 10 Wiki Activity

[BUG] server: Repair shows offline paths and untracked files incorrectly #1466

New Issue
Closed
opened 2026-02-05 01:56:05 +03:00 by OVERLORD · 4 comments
OVERLORD commented 2026-02-05 01:56:05 +03:00
Owner
Copy Link

Originally created by @waclaw66 on GitHub (Oct 17, 2023).

The bug

Repair shows as offline paths and untracked files:

  • trashed files
  • partner files

Those shouldn't be reported.

The OS that Immich Server is running on

Fedora 38

Version of Immich Server

v1.82.0

Version of Immich Mobile App

not relevant

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

not relevant

Your .env content

not relevant

Reproduction steps

not relevant

Additional information

No response

Originally created by @waclaw66 on GitHub (Oct 17, 2023). ### The bug Repair shows as offline paths and untracked files: - trashed files - partner files Those shouldn't be reported. ### The OS that Immich Server is running on Fedora 38 ### Version of Immich Server v1.82.0 ### Version of Immich Mobile App not relevant ### Platform with the issue - [X] Server - [ ] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML not relevant ``` ### Your .env content ```Shell not relevant ``` ### Reproduction steps ```bash not relevant ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 01:56:09 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Oct 17, 2023):

Can you elaborate on why those files should not be reported?

@alextran1502 commented on GitHub (Oct 17, 2023): Can you elaborate on why those files should not be reported?
OVERLORD commented 2026-02-05 01:56:15 +03:00
Author
Owner
Copy Link

@waclaw66 commented on GitHub (Oct 17, 2023):

Because they are in use and tracked. Only offline and untracked files shall be reported. I will debug the code tomorrow and give more details.

@waclaw66 commented on GitHub (Oct 17, 2023): Because they are in use and tracked. Only offline and untracked files shall be reported. I will debug the code tomorrow and give more details.
OVERLORD commented 2026-02-05 01:56:21 +03:00
Author
Owner
Copy Link

@waclaw66 commented on GitHub (Oct 17, 2023):

The problem is
5a9acbc05b/server/src/domain/audit/audit.service.ts (L125)

resolve doesn't expand the relative path like upload/library/82b637ca-7ad6-43cd-a15d-aad02... correctly.
IMMICH_MEDIA_LOCATION should be used instead.

@waclaw66 commented on GitHub (Oct 17, 2023): The problem is https://github.com/immich-app/immich/blob/5a9acbc05b8291cb33d56e877c9f84c85cd98fee/server/src/domain/audit/audit.service.ts#L125 `resolve` doesn't expand the relative path like `upload/library/82b637ca-7ad6-43cd-a15d-aad02...` correctly. `IMMICH_MEDIA_LOCATION` should be used instead.
OVERLORD commented 2026-02-05 01:56:22 +03:00
Author
Owner
Copy Link

@waclaw66 commented on GitHub (Oct 17, 2023):

Seems to be the same issue like https://github.com/immich-app/immich/issues/4507

@waclaw66 commented on GitHub (Oct 17, 2023): Seems to be the same issue like https://github.com/immich-app/immich/issues/4507
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1466
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?