immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[Feature]: Unify create user logic #146

New Issue
Closed
opened 2026-02-04 18:11:04 +03:00 by OVERLORD · 3 comments
OVERLORD commented 2026-02-04 18:11:04 +03:00
Owner
Copy Link

Originally created by @jbaez on GitHub (Jul 15, 2022).

Feature detail

Currently there are 2 endpoints that creates users introducing duplicated logic:

  • POST /auth/admin-sign-up
  • POST /user

They can be both merged into a single endpoint POST /user with the following business logic:

  • admin can only be created if no admin was created before
  • prevent creating a user with the same email
  • a user can be created only by the admin user

Platform

Server / Web / maybe Mobile

Originally created by @jbaez on GitHub (Jul 15, 2022). ### Feature detail Currently there are 2 endpoints that creates users introducing duplicated logic: - `POST /auth/admin-sign-up` - `POST /user` They can be both merged into a single endpoint `POST /user` with the following business logic: - admin can only be created if no admin was created before - prevent creating a user with the same email - a user can be created only by the admin user ### Platform Server / Web / maybe Mobile
OVERLORD commented 2026-02-04 18:11:14 +03:00
Author
Owner
Copy Link

@FelixHaimmerer commented on GitHub (Aug 20, 2022):

And it would be cool to add the function to delete users again.
Maybe in the add user screen a third button to delete the user. :)

@FelixHaimmerer commented on GitHub (Aug 20, 2022): And it would be cool to add the function to delete users again. Maybe in the add user screen a third button to delete the user. :)
OVERLORD commented 2026-02-04 18:11:29 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Dec 28, 2022):

Can this be closed? The logic is pretty much unified through user core. I also don't think it makes sense to merge an authenticated route with an unauthenticated one.

@jrasm91 commented on GitHub (Dec 28, 2022): Can this be closed? The logic is pretty much unified through user core. I also don't think it makes sense to merge an authenticated route with an unauthenticated one.
OVERLORD commented 2026-02-04 18:11:33 +03:00
Author
Owner
Copy Link

@jbaez commented on GitHub (Dec 28, 2022):

Yeah let's close this. I think now we probably only have some duplication in the request DTO validation. And yes you are right, it would make it more complicated to merge the API endpoints

@jbaez commented on GitHub (Dec 28, 2022): Yeah let's close this. I think now we probably only have some duplication in the request DTO validation. And yes you are right, it would make it more complicated to merge the API endpoints
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#146
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?