immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #14800] [MERGED] feat(server): Handle sidecars in external libraries #14352

New Issue
Closed
opened 2026-02-05 15:30:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:30:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/14800
Author: @etnoy
Created: 12/19/2024
Status: ✅ Merged
Merged: 12/22/2024
Merged by: @alextran1502

Base: main ← Head: fix/external-library-sidecars

📝 Commits (2)

  • d0bb59f handle sidecars in external libraries
  • 8868d38 don't add separate source

📊 Changes

5 files changed (+355 additions, -83 deletions)

View changed files

📝 e2e/src/api/specs/library.e2e-spec.ts (+339 -19)
📝 e2e/test-assets (+1 -1)
📝 server/src/services/library.service.spec.ts (+2 -53)
📝 server/src/services/library.service.ts (+5 -9)
📝 server/src/services/metadata.service.ts (+8 -1)

📄 Description

Recent improvements in sidecar handling in uploaded assets haven't propagated to external libraries before now.

With this PR, we correctly handle both file.jpg.xmp and file.xmp.

The key part is that we force a sidecar update for every metadata extraction of an external asset.

e2e tests added

A limitation that remains is that we don't automatically import changes when only the xmp is changed. The user will have to manually initiate a metadata refresh of the affected assets when this happens. This will be handled in the future by the planned asset file handling rework, but this depends on the kysely migration :) With the new asset file rework we will only re-discover xmp files when we actually need to.

This PR is a prerequisite for https://github.com/immich-app/immich/pull/14456

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/14800 **Author:** [@etnoy](https://github.com/etnoy) **Created:** 12/19/2024 **Status:** ✅ Merged **Merged:** 12/22/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/external-library-sidecars` --- ### 📝 Commits (2) - [`d0bb59f`](https://github.com/immich-app/immich/commit/d0bb59fac31f198051f1b65ccedf2b6cd6e5d643) handle sidecars in external libraries - [`8868d38`](https://github.com/immich-app/immich/commit/8868d3889c940ee054d6238792c255ce81bb56ed) don't add separate source ### 📊 Changes **5 files changed** (+355 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `e2e/src/api/specs/library.e2e-spec.ts` (+339 -19) 📝 `e2e/test-assets` (+1 -1) 📝 `server/src/services/library.service.spec.ts` (+2 -53) 📝 `server/src/services/library.service.ts` (+5 -9) 📝 `server/src/services/metadata.service.ts` (+8 -1) </details> ### 📄 Description Recent improvements in sidecar handling in uploaded assets haven't propagated to external libraries before now. With this PR, we correctly handle both file.jpg.xmp and file.xmp. The key part is that we force a sidecar update for every metadata extraction of an external asset. e2e tests added A limitation that remains is that we don't automatically import changes when only the xmp is changed. The user will have to manually initiate a metadata refresh of the affected assets when this happens. This will be handled in the future by the planned asset file handling rework, but this depends on the kysely migration :) With the new asset file rework we will only re-discover xmp files when we actually need to. This PR is a prerequisite for https://github.com/immich-app/immich/pull/14456 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:30:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#14352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?