immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #13704] [CLOSED] feat(web): Implement keep this delete others for asset stacks #14033

New Issue
Closed
opened 2026-02-05 15:25:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:25:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/13704
Author: @bdavis2-PCTY
Created: 10/23/2024
Status: ❌ Closed

Base: main ← Head: feature/keep-this-delete-others

📝 Commits (10+)

  • 83ca9bc Implement keep this delete others for asset stacks
  • f0e4eff Remove unused import
  • f2ba2f1 Code cleanup
  • 3e2b8ac Internationalize text
  • 0672e82 Change variable names
  • b6abc92 Change keepThisDeleteOthers function to accept asset and stack objects instead of ids
  • 6420550 Add confirmation dialog for keep this, delete others
  • 2fd10e5 Merge branch 'main' into feature/keep-this-delete-others
  • b9fafae Update i18n/en.json
  • 05514ed Reverse delete stacks/assets order

📊 Changes

653 files changed (+16619 additions, -12232 deletions)

View changed files

➕ .devcontainer/Dockerfile (+2 -0)
➕ .devcontainer/devcontainer.json (+20 -0)
📝 .github/workflows/docker-cleanup.yml (+2 -2)
➕ .github/workflows/fix-format.yml (+52 -0)
📝 .github/workflows/pr-require-conventional-commit.yml (+1 -1)
📝 .vscode/settings.json (+1 -1)
📝 Makefile (+8 -10)
📝 README.md (+2 -0)
📝 cli/.nvmrc (+1 -1)
📝 cli/Dockerfile (+1 -1)
📝 cli/package-lock.json (+200 -244)
📝 cli/package.json (+4 -4)
📝 cli/src/commands/asset.ts (+44 -16)
📝 cli/src/queue.ts (+2 -2)
📝 deployment/modules/cloudflare/docs-release/.terraform.lock.hcl (+30 -30)
📝 deployment/modules/cloudflare/docs-release/config.tf (+1 -1)
📝 deployment/modules/cloudflare/docs/.terraform.lock.hcl (+30 -30)
📝 deployment/modules/cloudflare/docs/config.tf (+1 -1)
📝 docker/docker-compose.dev.yml (+2 -2)
📝 docker/docker-compose.prod.yml (+4 -4)

...and 80 more files

📄 Description

Adds a new button when viewing a stacked asset to "Keep this, delete others."

This will result in deleting all the assets that are in the stack, except for the one that is currently being viewed.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/13704 **Author:** [@bdavis2-PCTY](https://github.com/bdavis2-PCTY) **Created:** 10/23/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/keep-this-delete-others` --- ### 📝 Commits (10+) - [`83ca9bc`](https://github.com/immich-app/immich/commit/83ca9bc9a7952cfe1e18031600cc6429b3762d62) Implement keep this delete others for asset stacks - [`f0e4eff`](https://github.com/immich-app/immich/commit/f0e4eff45a8fe0392728a9d3dda09b7a1b555d29) Remove unused import - [`f2ba2f1`](https://github.com/immich-app/immich/commit/f2ba2f111fcc7cbfe72f96e32c77969110378ba6) Code cleanup - [`3e2b8ac`](https://github.com/immich-app/immich/commit/3e2b8ac4162f0d68b34aa0b144b799512978eb42) Internationalize text - [`0672e82`](https://github.com/immich-app/immich/commit/0672e829dce91b667ebb32a77c7263ddcb1b3ff2) Change variable names - [`b6abc92`](https://github.com/immich-app/immich/commit/b6abc9241c880559a2b27615c130137fd63c7372) Change keepThisDeleteOthers function to accept asset and stack objects instead of ids - [`6420550`](https://github.com/immich-app/immich/commit/6420550c1df8fcaeb90741909279d4a4733fcbba) Add confirmation dialog for keep this, delete others - [`2fd10e5`](https://github.com/immich-app/immich/commit/2fd10e580e7cac1474eb29bdd85025e97b1d2499) Merge branch 'main' into feature/keep-this-delete-others - [`b9fafae`](https://github.com/immich-app/immich/commit/b9fafaea7dff5499418b42c91bd70d45cdd4eb6a) Update i18n/en.json - [`05514ed`](https://github.com/immich-app/immich/commit/05514ed1385eadfe01e26d0efdbed7a8b8eb1041) Reverse delete stacks/assets order ### 📊 Changes **653 files changed** (+16619 additions, -12232 deletions) <details> <summary>View changed files</summary> ➕ `.devcontainer/Dockerfile` (+2 -0) ➕ `.devcontainer/devcontainer.json` (+20 -0) 📝 `.github/workflows/docker-cleanup.yml` (+2 -2) ➕ `.github/workflows/fix-format.yml` (+52 -0) 📝 `.github/workflows/pr-require-conventional-commit.yml` (+1 -1) 📝 `.vscode/settings.json` (+1 -1) 📝 `Makefile` (+8 -10) 📝 `README.md` (+2 -0) 📝 `cli/.nvmrc` (+1 -1) 📝 `cli/Dockerfile` (+1 -1) 📝 `cli/package-lock.json` (+200 -244) 📝 `cli/package.json` (+4 -4) 📝 `cli/src/commands/asset.ts` (+44 -16) 📝 `cli/src/queue.ts` (+2 -2) 📝 `deployment/modules/cloudflare/docs-release/.terraform.lock.hcl` (+30 -30) 📝 `deployment/modules/cloudflare/docs-release/config.tf` (+1 -1) 📝 `deployment/modules/cloudflare/docs/.terraform.lock.hcl` (+30 -30) 📝 `deployment/modules/cloudflare/docs/config.tf` (+1 -1) 📝 `docker/docker-compose.dev.yml` (+2 -2) 📝 `docker/docker-compose.prod.yml` (+4 -4) _...and 80 more files_ </details> ### 📄 Description Adds a new button when viewing a stacked asset to "Keep this, delete others." This will result in deleting all the assets that are in the stack, except for the one that is currently being viewed. ![image](https://github.com/user-attachments/assets/79c964d9-32c0-442a-b292-9a59fc20e666) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:25:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#14033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?