immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #13593] [MERGED] fix(server): encodes iPhone 16 Pro video with unknown audio codec #13995

New Issue
Closed
opened 2026-02-05 15:24:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:24:40 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/13593
Author: @alextran1502
Created: 10/19/2024
Status: ✅ Merged
Merged: 10/19/2024
Merged by: @alextran1502

Base: main ← Head: fix/encode-video-iphone16pro

📝 Commits (6)

  • c9b5e6b fix(server): encodes iPhone 16 Pro video with unknown audio codec
  • f8498d9 remove white space
  • cbe38a0 pr feedback + unit test
  • aef9861 remove public method keyword
  • f42ef2b test the service
  • ec602bc correcting unit test

📊 Changes

3 files changed (+26 additions, -1 deletions)

View changed files

📝 server/src/services/media.service.spec.ts (+16 -0)
📝 server/src/services/media.service.ts (+3 -1)
📝 server/test/fixtures/media.stub.ts (+7 -0)

📄 Description

This PR introduces a fix for missing new audio codec from iPhone 16 Pro Max in FFmpeg build by picking the known codec in the audio streams.

Tested on FireFox on video that previously doesn't play because of missing encoded video, now can play successfully with sound

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/13593 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 10/19/2024 **Status:** ✅ Merged **Merged:** 10/19/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/encode-video-iphone16pro` --- ### 📝 Commits (6) - [`c9b5e6b`](https://github.com/immich-app/immich/commit/c9b5e6b9849b9eb46bcda2f8972fd2e61e5142d9) fix(server): encodes iPhone 16 Pro video with unknown audio codec - [`f8498d9`](https://github.com/immich-app/immich/commit/f8498d984a02869c2fb881e25aaca987942d1f03) remove white space - [`cbe38a0`](https://github.com/immich-app/immich/commit/cbe38a04967288a06c7f560c2e5694e6fbeed5ca) pr feedback + unit test - [`aef9861`](https://github.com/immich-app/immich/commit/aef9861ad4ad98e888e81711c921b478d2a204b9) remove public method keyword - [`f42ef2b`](https://github.com/immich-app/immich/commit/f42ef2bb7738e51d40d22d2403a80bec020b6b65) test the service - [`ec602bc`](https://github.com/immich-app/immich/commit/ec602bc36f2ad7d34e34a3b5070dfeb8fd38507c) correcting unit test ### 📊 Changes **3 files changed** (+26 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/src/services/media.service.spec.ts` (+16 -0) 📝 `server/src/services/media.service.ts` (+3 -1) 📝 `server/test/fixtures/media.stub.ts` (+7 -0) </details> ### 📄 Description This PR introduces a fix for missing new audio codec from iPhone 16 Pro Max in FFmpeg build by picking the known codec in the audio streams. Tested on FireFox on video that previously doesn't play because of missing encoded video, now can play successfully with sound --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:24:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#13995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?