immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #13108] [MERGED] refactor: service dependencies #13824

New Issue
Closed
opened 2026-02-05 15:21:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:21:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/13108
Author: @jrasm91
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/2/2024
Merged by: @jrasm91

Base: main ← Head: refactor/service-dependencies

📝 Commits (1)

  • 28ba7f9 refactor(server): simplify service dependency management

📊 Changes

77 files changed (+800 additions, -1860 deletions)

View changed files

📝 server/src/services/activity.service.spec.ts (+4 -6)
📝 server/src/services/activity.service.ts (+12 -18)
📝 server/src/services/album.service.spec.ts (+5 -17)
📝 server/src/services/album.service.ts (+15 -28)
📝 server/src/services/api-key.service.spec.ts (+4 -6)
📝 server/src/services/api-key.service.ts (+12 -18)
📝 server/src/services/asset-media.service.spec.ts (+4 -20)
📝 server/src/services/asset-media.service.ts (+9 -32)
📝 server/src/services/asset.service.spec.ts (+8 -42)
📝 server/src/services/asset.service.ts (+6 -32)
📝 server/src/services/audit.service.spec.ts (+2 -30)
📝 server/src/services/audit.service.ts (+6 -26)
📝 server/src/services/auth.service.spec.ts (+15 -45)
📝 server/src/services/auth.service.ts (+3 -24)
📝 server/src/services/base.service.ts (+83 -2)
📝 server/src/services/cli.service.spec.ts (+2 -20)
📝 server/src/services/cli.service.ts (+1 -17)
📝 server/src/services/database.service.spec.ts (+4 -8)
📝 server/src/services/database.service.ts (+3 -13)
📝 server/src/services/download.service.spec.ts (+3 -12)

...and 57 more files

📄 Description

Alternative dependency management for services and tests, in an attempt to reduce boilerplate code. Basically, all services have all repositories via the BaseService.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/13108 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/2/2024 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `refactor/service-dependencies` --- ### 📝 Commits (1) - [`28ba7f9`](https://github.com/immich-app/immich/commit/28ba7f9b4abdc71dbb1a8ba01906f16acba0cac4) refactor(server): simplify service dependency management ### 📊 Changes **77 files changed** (+800 additions, -1860 deletions) <details> <summary>View changed files</summary> 📝 `server/src/services/activity.service.spec.ts` (+4 -6) 📝 `server/src/services/activity.service.ts` (+12 -18) 📝 `server/src/services/album.service.spec.ts` (+5 -17) 📝 `server/src/services/album.service.ts` (+15 -28) 📝 `server/src/services/api-key.service.spec.ts` (+4 -6) 📝 `server/src/services/api-key.service.ts` (+12 -18) 📝 `server/src/services/asset-media.service.spec.ts` (+4 -20) 📝 `server/src/services/asset-media.service.ts` (+9 -32) 📝 `server/src/services/asset.service.spec.ts` (+8 -42) 📝 `server/src/services/asset.service.ts` (+6 -32) 📝 `server/src/services/audit.service.spec.ts` (+2 -30) 📝 `server/src/services/audit.service.ts` (+6 -26) 📝 `server/src/services/auth.service.spec.ts` (+15 -45) 📝 `server/src/services/auth.service.ts` (+3 -24) 📝 `server/src/services/base.service.ts` (+83 -2) 📝 `server/src/services/cli.service.spec.ts` (+2 -20) 📝 `server/src/services/cli.service.ts` (+1 -17) 📝 `server/src/services/database.service.spec.ts` (+4 -8) 📝 `server/src/services/database.service.ts` (+3 -13) 📝 `server/src/services/download.service.spec.ts` (+3 -12) _...and 57 more files_ </details> ### 📄 Description Alternative dependency management for services and tests, in an attempt to reduce boilerplate code. Basically, all services have all repositories via the `BaseService`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:21:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#13824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?