immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #12102] [MERGED] fix(server): ensure new exclusion patterns work #13482

New Issue
Closed
opened 2026-02-05 15:15:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:15:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/12102
Author: @etnoy
Created: 8/29/2024
Status: ✅ Merged
Merged: 8/29/2024
Merged by: @jrasm91

Base: main ← Head: fix/offline-by-exclusion

📝 Commits (10+)

📊 Changes

6 files changed (+85 additions, -20 deletions)

View changed files

📝 e2e/src/api/specs/library.e2e-spec.ts (+53 -14)
📝 server/package-lock.json (+2 -1)
📝 server/package.json (+1 -1)
📝 server/src/interfaces/job.interface.ts (+1 -0)
📝 server/src/services/library.service.spec.ts (+20 -1)
📝 server/src/services/library.service.ts (+8 -3)

📄 Description

It appears that a new exclusion pattern doesn't take effect for setting assets offline. A regression from #7934

  • Add e2e test case
  • Add a check for exclusion pattern in the offline asset cherker
  • Bump picomatch
  • Cleanup library e2e tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/12102 **Author:** [@etnoy](https://github.com/etnoy) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 8/29/2024 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/offline-by-exclusion` --- ### 📝 Commits (10+) - [`2385b9a`](https://github.com/immich-app/immich/commit/2385b9af5c4ee9e37e047667072f06400aab62ee) add test for bug - [`a9eb39b`](https://github.com/immich-app/immich/commit/a9eb39b9588074b11afc43cb3f3dd654c6fd1465) find excluded paths when checking offline - [`1e027d0`](https://github.com/immich-app/immich/commit/1e027d0a69cb532cbadf56e527f0ec3f07cf3f8d) fix filename - [`957b89e`](https://github.com/immich-app/immich/commit/957b89efb8a975b0e5083239de98de4014ca1c81) fix unit tests - [`0efdcaa`](https://github.com/immich-app/immich/commit/0efdcaaf18e8e581804142ad4efd0bae661326f2) bump picomatch - [`ffd043d`](https://github.com/immich-app/immich/commit/ffd043dddf2d275ff488e62d5180b672687f173e) fix e2e paths - [`d96b632`](https://github.com/immich-app/immich/commit/d96b6323698b8565632bdde931a5c62636adce9c) Merge branch 'main' of https://github.com/immich-app/immich into fix/offline-by-exclusion - [`6e96980`](https://github.com/immich-app/immich/commit/6e9698015be413f149efc6224ee9d3e38cfa5248) improve e2e - [`a023740`](https://github.com/immich-app/immich/commit/a023740173eaa98990db6876a7a0d1662b32413a) add unit tests - [`8790463`](https://github.com/immich-app/immich/commit/87904635b4df00488ffaccb4afeba58958ebde80) cleanup e2e ### 📊 Changes **6 files changed** (+85 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `e2e/src/api/specs/library.e2e-spec.ts` (+53 -14) 📝 `server/package-lock.json` (+2 -1) 📝 `server/package.json` (+1 -1) 📝 `server/src/interfaces/job.interface.ts` (+1 -0) 📝 `server/src/services/library.service.spec.ts` (+20 -1) 📝 `server/src/services/library.service.ts` (+8 -3) </details> ### 📄 Description It appears that a new exclusion pattern doesn't take effect for setting assets offline. A regression from #7934 * Add e2e test case * Add a check for exclusion pattern in the offline asset cherker * Bump picomatch * Cleanup library e2e tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 15:15:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#13482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?