immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #10667] fix(web): remove black bezels + better integrate ActivityStatus #12971

New Issue
Closed
opened 2026-02-05 15:06:38 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:06:38 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/10667

State: closed
Merged: Yes

My entire description was deleted so I'll keep it brief I guess.

Fixes #10526

image

Couldn't test properly cos the headers-already-sent bug broke the video and changed the appearance of the controls but think it's OK.

Tried to right-align the buttons and make ActivityControl as-if a kind of second-row from the bottom, symmetrical to the top row. TODO: It should be first-row from bottom on PhotoViewer but idk how to condition in Svelte macros for PhotoViewer vs VideoViewer appearing.

Tried to also make ActivityControl less obtrusive, so removed the "Say Something" text (because it does not fade out nor disappear if the viewport width is decreased). I left the code in a comment and noted these two conditions for maybe bringing it back, tho it's a bit subjective whether it's useful or not.

**Original Pull Request:** https://github.com/immich-app/immich/pull/10667 **State:** closed **Merged:** Yes --- My entire description was deleted so I'll keep it brief I guess. Fixes #10526 ![image](https://github.com/immich-app/immich/assets/28405293/d1816820-8590-4ecd-9be6-d09f2c99279b) Couldn't test properly cos the headers-already-sent bug broke the video and changed the appearance of the controls but think it's OK. Tried to right-align the buttons and make ActivityControl as-if a kind of second-row from the bottom, symmetrical to the top row. **TODO**: It should be first-row from bottom on PhotoViewer but idk how to condition in Svelte macros for PhotoViewer vs VideoViewer appearing. Tried to also make ActivityControl less obtrusive, so removed the "Say Something" text (because it does not fade out nor disappear if the viewport width is decreased). I left the code in a comment and noted these two conditions for maybe bringing it back, tho it's a bit subjective whether it's useful or not.
OVERLORD added the pull-request label 2026-02-05 15:06:38 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12971
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?