immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #10491] feat(web): translations containing html #12910

New Issue
Closed
opened 2026-02-05 15:05:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:05:36 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/10491

State: closed
Merged: Yes

Adds the ability to translate messages that contain HTML by building on Rich Text Formatting provided by formatjs. Because svelte-i18n doesn't export the needed function, the libraries are used directly.

The implementation considers the following:

  • tags in a translation can change position
  • translators can easily see the context and the syntax should be easy to reduce errors
  • alternative solutions are often susceptible to xss by using @html
**Original Pull Request:** https://github.com/immich-app/immich/pull/10491 **State:** closed **Merged:** Yes --- Adds the ability to translate messages that contain HTML by building on [Rich Text Formatting](https://formatjs.io/docs/core-concepts/icu-syntax#rich-text-formatting) provided by `formatjs`. Because `svelte-i18n` doesn't export the needed function, the libraries are used directly. The implementation considers the following: - tags in a translation can change position - translators can easily see the context and the syntax should be easy to reduce errors - alternative solutions are often susceptible to xss by using `@html`
OVERLORD added the pull-request label 2026-02-05 15:05:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12910
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?