immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #10167] fix(server): exiftool largefilesupport only set for the first call #12805

New Issue
Closed
opened 2026-02-05 15:03:49 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:03:49 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/10167

State: closed
Merged: Yes

The previous largefilesupport fix doesn't work as it should since exiftool is used as a long-running process in stay_open mode. In this mode, flags passed when spawning the process only take effect until the first -execute, after which the flags are reset. So the previous fix for largefilesupport only works for the first operation.

This branch reverts that fix and instead passes the largefilesupport flags to the write read command each time, which results in the flag being set for each operation and ensures that large files work for all metadata read operations.

I also noticed exiftool being used for extractBinaryTagToBuffer and writeTags. The former doesn't appear to have any way to add largefilesupport flags and the latter appears to be only for sidecar metadata files so it probably isn't needed, but could probably be added there too.

Fixes #4349

**Original Pull Request:** https://github.com/immich-app/immich/pull/10167 **State:** closed **Merged:** Yes --- The previous largefilesupport fix doesn't work as it should since exiftool is used as a long-running process in `stay_open` mode. In this mode, flags passed when spawning the process only take effect until the first `-execute`, after which the flags are reset. So the previous fix for largefilesupport only works for the first operation. This branch reverts that fix and instead passes the largefilesupport flags to the <strike>write</strike> read command each time, which results in the flag being set for each operation and ensures that large files work for all metadata read operations. I also noticed exiftool being used for `extractBinaryTagToBuffer` and `writeTags`. The former doesn't appear to have any way to add largefilesupport flags and the latter appears to be only for sidecar metadata files so it probably isn't needed, but could probably be added there too. Fixes #4349
OVERLORD added the pull-request label 2026-02-05 15:03:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12805
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?