immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #10028] fix: prevent trashing of trashed assets #12739

New Issue
Closed
opened 2026-02-05 15:02:33 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:02:33 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/10028

State: closed
Merged: Yes

Motivation

This will improve user experience by hiding a pointless action by changing "move to trash" into "delete permanently" if the asset is already in the trash.

You can not trash a trashed asset again. It won't get any trashier than it already is.

How to test

  1. Visit route /trash
  2. Click on an asset
  3. Press "Delete" on your keyboard
  4. You will see the confirmation dialog to permanently delete the asset
  5. Click on the trash button in the top right
  6. Same as 4)
**Original Pull Request:** https://github.com/immich-app/immich/pull/10028 **State:** closed **Merged:** Yes --- Motivation ---------- This will improve user experience ~by hiding a pointless action~ by changing "move to trash" into "delete permanently" if the asset is already in the trash. ~You can not trash a trashed asset again. It won't get any trashier than it already is.~ How to test ----------- 1. Visit route `/trash` 2. Click on an asset 3. Press "Delete" on your keyboard 4. You will see the confirmation dialog to permanently delete the asset 5. Click on the trash button in the top right 6. Same as 4)
OVERLORD added the pull-request label 2026-02-05 15:02:33 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12739
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?