immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #9800] chore: refactor transcode config routing #12643

New Issue
Closed
opened 2026-02-05 15:00:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:00:44 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/9800

State: closed
Merged: Yes

Description

The transcode config to use is currently handled in the media service. This PR moves it to the util instead as the routing is somewhat complex and should be considered an implementation detail. Creating a config is now declarative, without the service needing to care about what config it really is.

Also renames TranscodeOptions to TranscodeCommand and getOptions to getCommand. This is to better distinguish it from the admin config.

Lastly, it removes some uses of null in the service.

**Original Pull Request:** https://github.com/immich-app/immich/pull/9800 **State:** closed **Merged:** Yes --- ## Description The transcode config to use is currently handled in the media service. This PR moves it to the util instead as the routing is somewhat complex and should be considered an implementation detail. Creating a config is now declarative, without the service needing to care about what config it really is. Also renames `TranscodeOptions` to `TranscodeCommand` and `getOptions` to `getCommand`. This is to better distinguish it from the admin config. Lastly, it removes some uses of `null` in the service.
OVERLORD added the pull-request label 2026-02-05 15:00:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?