immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #9789] fix(web): validation of number input fields #12641

New Issue
Closed
opened 2026-02-05 15:00:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:00:42 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/9789

State: closed
Merged: Yes

#9470 tried to prevent number inputs from changing empty fields to zero while the user is still changing the value. This was done by validating on:blur instead of on:input, but there are certain cases where on:blur won't fire (scrolling, using arrows, submitting form) and validation won't happen.

This issue is resolved by using on:change, which triggers only after the user has finished typing a number and also fires when the value was changed using other input methods.

With number validation fixed, adding type="submit" to the save button enables submitting admin settings using the enter key.

**Original Pull Request:** https://github.com/immich-app/immich/pull/9789 **State:** closed **Merged:** Yes --- #9470 tried to prevent number inputs from changing empty fields to zero while the user is still changing the value. This was done by validating on:blur instead of on:input, but there are certain cases where on:blur won't fire (scrolling, using arrows, submitting form) and validation won't happen. This issue is resolved by using `on:change`, which triggers only after the user has finished typing a number and also fires when the value was changed using other input methods. With number validation fixed, adding `type="submit"` to the save button enables submitting admin settings using the enter key.
OVERLORD added the pull-request label 2026-02-05 15:00:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?