immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #9714] test: reorder tests in asset.e2e-spec.ts #12607

New Issue
Closed
opened 2026-02-05 15:00:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:00:03 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/9714

State: closed
Merged: Yes

This reorders some tests in prep for later a later PR that will re-use the POST createAsset api method to be run in a loop with the replaceAsset api method.

This moves the POST tests to the end of the file, since we need to rerun setup on a clean db for every loop. This also broke the map-marker tests, since they were using assets created earlier in the suite - so we create a new setup method for those test that just upload the tests.

finally, move some of the for loops that define tests to use it.each() which is just a tiny bit nicer.

**Original Pull Request:** https://github.com/immich-app/immich/pull/9714 **State:** closed **Merged:** Yes --- This reorders some tests in prep for later a later PR that will re-use the POST createAsset api method to be run in a loop with the replaceAsset api method. This moves the POST tests to the end of the file, since we need to rerun setup on a clean db for every loop. This also broke the map-marker tests, since they were using assets created earlier in the suite - so we create a new setup method for those test that just upload the tests. finally, move some of the for loops that define tests to use it.each() which is just a tiny bit nicer.
OVERLORD added the pull-request label 2026-02-05 15:00:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12607
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?