immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #9088] fix(cli): dry run being inaccurate #12323

New Issue
Closed
opened 2026-02-05 14:54:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:54:57 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/9088

State: closed
Merged: Yes

Description

The dry run always returns an empty list for the list of new assets, meaning it will always report that it would create 0 new albums. This PR changes this to return a list of dummy assets instead for accurate reporting.

It also adds a bunch of e2e tests for dry runs since we seem to not test this flag at all right now.

Lastly, it makes dry runs incompatible with the --skip-hash flag since duplicates can't be accurately handled in this case.

Fixes #8966

How Has This Been Tested?

Tested that the dry run lines up with the real run with a number of different commands.

**Original Pull Request:** https://github.com/immich-app/immich/pull/9088 **State:** closed **Merged:** Yes --- ## Description The dry run always returns an empty list for the list of new assets, meaning it will always report that it would create 0 new albums. This PR changes this to return a list of dummy assets instead for accurate reporting. It also adds a bunch of e2e tests for dry runs since we seem to not test this flag at all right now. Lastly, it makes dry runs incompatible with the `--skip-hash` flag since duplicates can't be accurately handled in this case. Fixes #8966 ## How Has This Been Tested? Tested that the dry run lines up with the real run with a number of different commands.
OVERLORD added the pull-request label 2026-02-05 14:54:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#12323
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?