immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #7709] refactor: api validators (boolean and date) #11754

New Issue
Closed
opened 2026-02-05 14:45:17 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:45:17 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/7709

State: closed
Merged: Yes

  • no longer allow so many "date" options, like false, 0, etc.
  • standardize date validation (using isDateString)
  • standardize boolean validation (correctly converts 'false' and 'true' in query params, etc.

The e2e tests for the cli failed without fileCreatedAt.toISOString() after these changes, which now require valid date strings. I'm not sure what it was doing before but it is possible it was not working correctly.

**Original Pull Request:** https://github.com/immich-app/immich/pull/7709 **State:** closed **Merged:** Yes --- * no longer allow so many "date" options, like `false`, 0, etc. * standardize date validation (using isDateString) * standardize boolean validation (correctly converts `'false'` and `'true'` in query params, etc. The e2e tests for the cli failed without `fileCreatedAt.toISOString()` after these changes, which now require valid date strings. I'm not sure what it was doing before but it is possible it was not working correctly.
OVERLORD added the pull-request label 2026-02-05 14:45:17 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11754
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?