immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #7480] [MERGED] chore: remove watcher polling option #11652

New Issue
Closed
opened 2026-02-05 14:43:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:43:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7480
Author: @etnoy
Created: 2/28/2024
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @etnoy

Base: main ← Head: chore/remove-watch-polling

📝 Commits (3)

📊 Changes

14 files changed (+18 additions, -107 deletions)

View changed files

📝 docs/docs/features/libraries.md (+1 -4)
📝 mobile/openapi/doc/SystemConfigLibraryWatchDto.md (+0 -2)
📝 mobile/openapi/lib/model/system_config_library_watch_dto.dart (+3 -19)
📝 mobile/openapi/test/system_config_library_watch_dto_test.dart (+0 -10)
📝 open-api/immich-openapi-specs.json (+1 -9)
📝 open-api/typescript-sdk/axios-client/api.ts (+0 -12)
📝 open-api/typescript-sdk/fetch-client.ts (+0 -2)
📝 server/src/domain/library/library.service.ts (+1 -8)
📝 server/src/domain/system-config/dto/system-config-library.dto.ts (+0 -11)
📝 server/src/domain/system-config/system-config.core.ts (+0 -2)
📝 server/src/domain/system-config/system-config.service.spec.ts (+0 -2)
📝 server/src/infra/entities/system-config.entity.ts (+0 -4)
➕ server/src/infra/migrations/1709150004123-RemoveLibraryWatchPollingOption.ts (+12 -0)
📝 web/src/lib/components/admin-page/settings/library-settings/library-settings.svelte (+0 -22)

📄 Description

Polling for the library watcher only seems to bring problems. If users want to rescan libraries automatically we should probably have them use the cron feature instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7480 **Author:** [@etnoy](https://github.com/etnoy) **Created:** 2/28/2024 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@etnoy](https://github.com/etnoy) **Base:** `main` ← **Head:** `chore/remove-watch-polling` --- ### 📝 Commits (3) - [`141c1c6`](https://github.com/immich-app/immich/commit/141c1c6e0628372939b9b59be1192b7f8dc66cf8) remove watcher polling - [`b6405df`](https://github.com/immich-app/immich/commit/b6405df604d38e8f0b21154d61102fa20382be80) fix lint - [`aa54bac`](https://github.com/immich-app/immich/commit/aa54baca365a7c55b2b486f63a62b4afef038406) add db migration ### 📊 Changes **14 files changed** (+18 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `docs/docs/features/libraries.md` (+1 -4) 📝 `mobile/openapi/doc/SystemConfigLibraryWatchDto.md` (+0 -2) 📝 `mobile/openapi/lib/model/system_config_library_watch_dto.dart` (+3 -19) 📝 `mobile/openapi/test/system_config_library_watch_dto_test.dart` (+0 -10) 📝 `open-api/immich-openapi-specs.json` (+1 -9) 📝 `open-api/typescript-sdk/axios-client/api.ts` (+0 -12) 📝 `open-api/typescript-sdk/fetch-client.ts` (+0 -2) 📝 `server/src/domain/library/library.service.ts` (+1 -8) 📝 `server/src/domain/system-config/dto/system-config-library.dto.ts` (+0 -11) 📝 `server/src/domain/system-config/system-config.core.ts` (+0 -2) 📝 `server/src/domain/system-config/system-config.service.spec.ts` (+0 -2) 📝 `server/src/infra/entities/system-config.entity.ts` (+0 -4) ➕ `server/src/infra/migrations/1709150004123-RemoveLibraryWatchPollingOption.ts` (+12 -0) 📝 `web/src/lib/components/admin-page/settings/library-settings/library-settings.svelte` (+0 -22) </details> ### 📄 Description Polling for the library watcher only seems to bring problems. If users want to rescan libraries automatically we should probably have them use the cron feature instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:43:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11652
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?