immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #7456] [MERGED] fix(web): don't ask password for invalid shared link #11629

New Issue
Closed
opened 2026-02-05 14:43:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:43:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7456
Author: @michelheusschen
Created: 2/27/2024
Status: ✅ Merged
Merged: 2/27/2024
Merged by: @alextran1502

Base: main ← Head: fix/web-shared-link-password

📝 Commits (2)

  • 348e171 fix(web): don't ask password for invalid shared link
  • 9d9a6d5 use apiUtils for e2e test

📊 Changes

3 files changed (+34 additions, -20 deletions)

View changed files

📝 e2e/src/web/specs/shared-link.e2e-spec.ts (+22 -10)
📝 web/src/routes/(user)/share/[key]/+error.svelte (+9 -2)
📝 web/src/routes/(user)/share/[key]/+page.ts (+3 -8)

📄 Description

Show Invalid share key message (passed through from server) instead of asking for password input for invalid shared links. Also adds e2e tests for this

invalid-shared-link-error

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7456 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 2/27/2024 **Status:** ✅ Merged **Merged:** 2/27/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/web-shared-link-password` --- ### 📝 Commits (2) - [`348e171`](https://github.com/immich-app/immich/commit/348e171758768b6dc54db350f8850fb186a11e86) fix(web): don't ask password for invalid shared link - [`9d9a6d5`](https://github.com/immich-app/immich/commit/9d9a6d5901080bafe680d18560e55e915f2eca15) use apiUtils for e2e test ### 📊 Changes **3 files changed** (+34 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `e2e/src/web/specs/shared-link.e2e-spec.ts` (+22 -10) 📝 `web/src/routes/(user)/share/[key]/+error.svelte` (+9 -2) 📝 `web/src/routes/(user)/share/[key]/+page.ts` (+3 -8) </details> ### 📄 Description Show `Invalid share key` message (passed through from server) instead of asking for password input for invalid shared links. Also adds e2e tests for this ![invalid-shared-link-error](https://github.com/immich-app/immich/assets/59014050/5b7cb84c-b4da-4701-b109-58cba8670a57) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:43:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?