immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-25 03:12:21 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #7389] [MERGED] Fix Smart Search when using OpenVINO #11613

New Issue
Closed
opened 2026-02-05 14:42:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:42:44 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7389
Author: @agrawalsourav98
Created: 2/24/2024
Status: ✅ Merged
Merged: 2/25/2024
Merged by: @mertalev

Base: main ← Head: fix-openvino-clip-inference

📝 Commits (9)

📊 Changes

6 files changed (+41 additions, -64 deletions)

View changed files

📝 machine-learning/ann/__init__.py (+0 -1)
📝 machine-learning/ann/ann.py (+1 -2)
📝 machine-learning/app/models/base.py (+13 -53)
📝 machine-learning/app/models/constants.py (+0 -3)
📝 machine-learning/app/test_main.py (+24 -2)
📝 machine-learning/pyproject.toml (+3 -3)

📄 Description

This PR fixes smart search when using OpenVINO. See discussion #6869

The issue is caused due to the following bug in upstream, see here and fixed by this.

As this is the part of the v1.17.0 release and the onnxruntime_openvino package has not been updated in a while, this PR fixes the issue by changing the dir to where the external_data is loaded before the onnxruntime session is created.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7389 **Author:** [@agrawalsourav98](https://github.com/agrawalsourav98) **Created:** 2/24/2024 **Status:** ✅ Merged **Merged:** 2/25/2024 **Merged by:** [@mertalev](https://github.com/mertalev) **Base:** `main` ← **Head:** `fix-openvino-clip-inference` --- ### 📝 Commits (9) - [`4ce7011`](https://github.com/immich-app/immich/commit/4ce701135e738fbd9f0301991a031c9d6e7de492) Fix external_path loading in OpenVINO EP - [`a3f0800`](https://github.com/immich-app/immich/commit/a3f0800d8822055ad405f73186643f987d3f3eb0) Fix ruff lint - [`cc2ac0a`](https://github.com/immich-app/immich/commit/cc2ac0ae315c1ba75b99ec659cc62c501fb0208a) Wrap block in try finally - [`ca2d04d`](https://github.com/immich-app/immich/commit/ca2d04d5d486416e1a691d4bcbb57cf99920b271) remove static input shape code - [`cd91cae`](https://github.com/immich-app/immich/commit/cd91caecf09d8fc53fdac7d6ff6039f31fb2793e) add unit test - [`7d344ce`](https://github.com/immich-app/immich/commit/7d344ce27d4869dde136445dc7551f79d59a5846) remove unused imports - [`5612654`](https://github.com/immich-app/immich/commit/5612654578e173d06089f35c67109b881865912e) remove repeat line - [`5bc69be`](https://github.com/immich-app/immich/commit/5bc69be80932fc974de6981768d4065a0c646ea7) linting - [`b1af2b6`](https://github.com/immich-app/immich/commit/b1af2b61beae112e3a14ee55e31a30617c7ffe88) formatting ### 📊 Changes **6 files changed** (+41 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `machine-learning/ann/__init__.py` (+0 -1) 📝 `machine-learning/ann/ann.py` (+1 -2) 📝 `machine-learning/app/models/base.py` (+13 -53) 📝 `machine-learning/app/models/constants.py` (+0 -3) 📝 `machine-learning/app/test_main.py` (+24 -2) 📝 `machine-learning/pyproject.toml` (+3 -3) </details> ### 📄 Description This PR fixes smart search when using OpenVINO. See discussion #6869 The issue is caused due to the following bug in upstream, see [here](https://github.com/microsoft/onnxruntime/issues/17499) and fixed by [this](https://github.com/microsoft/onnxruntime/pull/18596). As this is the part of the `v1.17.0` release and the `onnxruntime_openvino` package has not been updated in a while, this PR fixes the issue by changing the dir to where the external_data is loaded before the onnxruntime session is created. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:42:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11613
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?