immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-24 19:08:04 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #7391] [MERGED] fix(web): fetch error reporting #11610

New Issue
Closed
opened 2026-02-05 14:42:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:42:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7391
Author: @michelheusschen
Created: 2/24/2024
Status: ✅ Merged
Merged: 2/27/2024
Merged by: @alextran1502

Base: main ← Head: fix/web-fetch-error-handling

📝 Commits (1)

  • 4db49e9 fix(web): fetch error reporting

📊 Changes

4 files changed (+43 additions, -32 deletions)

View changed files

➕ open-api/typescript-sdk/fetch-errors.ts (+15 -0)
📝 open-api/typescript-sdk/fetch.ts (+1 -0)
📝 web/src/hooks.client.ts (+10 -22)
📝 web/src/lib/utils/handle-error.ts (+17 -10)

📄 Description

Fetch errors don't show the error message returned from API responses, because it only expects axios errors. Fixed by handling both fetch and axios errors in the handleError function. The client hook has been changed to only handle fetch errors, because we don't use axios in any page load functions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7391 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 2/24/2024 **Status:** ✅ Merged **Merged:** 2/27/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/web-fetch-error-handling` --- ### 📝 Commits (1) - [`4db49e9`](https://github.com/immich-app/immich/commit/4db49e9e1db586fe8f89068863f7f93f92ed9295) fix(web): fetch error reporting ### 📊 Changes **4 files changed** (+43 additions, -32 deletions) <details> <summary>View changed files</summary> ➕ `open-api/typescript-sdk/fetch-errors.ts` (+15 -0) 📝 `open-api/typescript-sdk/fetch.ts` (+1 -0) 📝 `web/src/hooks.client.ts` (+10 -22) 📝 `web/src/lib/utils/handle-error.ts` (+17 -10) </details> ### 📄 Description Fetch errors don't show the error message returned from API responses, because it only expects axios errors. Fixed by handling both fetch and axios errors in the `handleError` function. The client hook has been changed to only handle fetch errors, because we don't use axios in any page load functions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:42:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11610
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?