immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[BUG] Accepted file type mismatch between new CLI and server/web #1159

New Issue
Closed
opened 2026-02-05 00:41:33 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 00:41:33 +03:00
Owner
Copy Link

Originally created by @sethbaird01 on GitHub (Jul 26, 2023).

Originally assigned to: @jrasm91 on GitHub.

The bug

Server and web do not support .tif files while new CLI does. This causes it to upload such unsupported files resulting in ERR_BAD_REQUEST.

Error during upload:
image1
image2

Diff between types listed in web/src/lib/utils/file-uploader.ts and server/src/domain/asset/asset.service.spec.ts
diff

Could be fixed by changing line 12 in CLI's supported files from const tiff = ['tif', 'tiff']; to const tiff = ['tiff']; 1c5926553a/cli/src/cores/constants.ts (L12)

I tried this locally and the upload proceeded without issue. Not sure if this would pass tests though, since ".tif" is mentioned in the spec file cli/src/services/crawl.service.spec.ts

The OS that Immich Server is running on

TrueNAS 22.12.3.2

Version of Immich Server

1.69.0

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Login to the server through new CLI
2. Upload a .tif file or a folder containing one
3. Error

Additional information

No response

Originally created by @sethbaird01 on GitHub (Jul 26, 2023). Originally assigned to: @jrasm91 on GitHub. ### The bug Server and web do not support .tif files while new CLI does. This causes it to upload such unsupported files resulting in ERR_BAD_REQUEST. Error during upload: ![image1](https://github.com/immich-app/immich/assets/58704551/37f36f43-821f-41ae-a96b-d63c95875efe) ![image2](https://github.com/immich-app/immich/assets/58704551/ccfb1495-e70c-4152-941a-8acc970cdc2f) Diff between types listed in web/src/lib/utils/file-uploader.ts and server/src/domain/asset/asset.service.spec.ts ![diff](https://github.com/immich-app/immich/assets/58704551/3d2401b3-6852-4352-b66a-0000cb1ef28b) Could be fixed by changing line 12 in CLI's supported files from `const tiff = ['tif', 'tiff'];` to `const tiff = ['tiff'];` https://github.com/immich-app/immich/blob/1c5926553a7fba7a6eaf24be63181a61e6b763d7/cli/src/cores/constants.ts#L12 I tried this locally and the upload proceeded without issue. Not sure if this would pass tests though, since ".tif" is mentioned in the spec file cli/src/services/crawl.service.spec.ts ### The OS that Immich Server is running on TrueNAS 22.12.3.2 ### Version of Immich Server 1.69.0 ### Version of Immich Mobile App N/A ### Platform with the issue - [ ] Server - [ ] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash 1. Login to the server through new CLI 2. Upload a .tif file or a folder containing one 3. Error ``` ### Additional information _No response_
OVERLORD added the format label 2026-02-05 00:41:33 +03:00
OVERLORD commented 2026-02-05 00:41:39 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Jul 26, 2023):

Hello, what version of the CLI are you running?

Ah we talked about this in Discord

@alextran1502 commented on GitHub (Jul 26, 2023): ~~Hello, what version of the CLI are you running?~~ Ah we talked about this in Discord
OVERLORD commented 2026-02-05 00:41:44 +03:00
Author
Owner
Copy Link

@etnoy commented on GitHub (Jul 27, 2023):

For reference, it's the new cli version in the main repo.

Thanks for a really nice writeup, we should be able to fix this quickly!

@etnoy commented on GitHub (Jul 27, 2023): For reference, it's the new cli version in the main repo. Thanks for a really nice writeup, we should be able to fix this quickly!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label format
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1159
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?