immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #7110] [MERGED] chore: enum support for new API #11485

New Issue
Closed
opened 2026-02-05 14:40:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:40:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7110
Author: @benmccann
Created: 2/14/2024
Status: ✅ Merged
Merged: 2/14/2024
Merged by: @benmccann

Base: main ← Head: one-enum

📝 Commits (3)

📊 Changes

108 files changed (+540 additions, -374 deletions)

View changed files

📝 open-api/bin/generate-open-api.sh (+1 -1)
📝 open-api/typescript-sdk/fetch-client.ts (+192 -36)
📝 open-api/typescript-sdk/tsconfig.fetch.json (+1 -1)
➖ web/src/api/index.ts (+0 -3)
➖ web/src/api/types.ts (+0 -8)
➖ web/src/api/utils.ts (+0 -63)
📝 web/src/lib/api/index.ts (+3 -5)
📝 web/src/lib/components/admin-page/jobs/job-tile.svelte (+1 -2)
📝 web/src/lib/components/admin-page/jobs/jobs-panel.svelte (+1 -2)
📝 web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte (+9 -2)
📝 web/src/lib/components/admin-page/settings/job-settings/job-settings.svelte (+3 -3)
📝 web/src/lib/components/admin-page/settings/logging-settings/logging-settings.svelte (+1 -2)
📝 web/src/lib/components/admin-page/settings/thumbnail/thumbnail-settings.svelte (+1 -2)
📝 web/src/lib/components/album-page/__tests__/album-card.spec.ts (+5 -4)
📝 web/src/lib/components/album-page/album-card.svelte (+2 -2)
📝 web/src/lib/components/album-page/album-options.svelte (+3 -3)
📝 web/src/lib/components/album-page/album-viewer.svelte (+1 -1)
📝 web/src/lib/components/album-page/share-info-modal.svelte (+1 -2)
📝 web/src/lib/components/album-page/thumbnail-selection.svelte (+1 -1)
📝 web/src/lib/components/asset-viewer/activity-status.svelte (+1 -1)

...and 80 more files

📄 Description

@jrasm91 has been doing a great job migrating the API over. One of the TODOs from https://github.com/immich-app/immich/pull/7103 was enums. I got that setup and working in this PR. I only migrated a single enum as a demonstration to avoid creating merge conflicts with his outstanding PR

Looks like this is causing a bunch of type errors, so there are a bunch of places we'll need to update imports from @api to @immich/sdk. It's probably best to wait for https://github.com/immich-app/immich/pull/7103 before doing that. Feel free to take this over as I have a busy day tomorrow or else I'll get back to it later in the week

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7110 **Author:** [@benmccann](https://github.com/benmccann) **Created:** 2/14/2024 **Status:** ✅ Merged **Merged:** 2/14/2024 **Merged by:** [@benmccann](https://github.com/benmccann) **Base:** `main` ← **Head:** `one-enum` --- ### 📝 Commits (3) - [`f8d0fb2`](https://github.com/immich-app/immich/commit/f8d0fb20c60e31b7c838b98645a40cfad9c8eeaf) chore: enum support for new API - [`7d2650c`](https://github.com/immich-app/immich/commit/7d2650c4fd12d4a26863d142fce83929fec4869c) fix type error - [`a2b1221`](https://github.com/immich-app/immich/commit/a2b12216254b2fdd396b7459bb4984955929589a) chore: migrate enum types ### 📊 Changes **108 files changed** (+540 additions, -374 deletions) <details> <summary>View changed files</summary> 📝 `open-api/bin/generate-open-api.sh` (+1 -1) 📝 `open-api/typescript-sdk/fetch-client.ts` (+192 -36) 📝 `open-api/typescript-sdk/tsconfig.fetch.json` (+1 -1) ➖ `web/src/api/index.ts` (+0 -3) ➖ `web/src/api/types.ts` (+0 -8) ➖ `web/src/api/utils.ts` (+0 -63) 📝 `web/src/lib/api/index.ts` (+3 -5) 📝 `web/src/lib/components/admin-page/jobs/job-tile.svelte` (+1 -2) 📝 `web/src/lib/components/admin-page/jobs/jobs-panel.svelte` (+1 -2) 📝 `web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte` (+9 -2) 📝 `web/src/lib/components/admin-page/settings/job-settings/job-settings.svelte` (+3 -3) 📝 `web/src/lib/components/admin-page/settings/logging-settings/logging-settings.svelte` (+1 -2) 📝 `web/src/lib/components/admin-page/settings/thumbnail/thumbnail-settings.svelte` (+1 -2) 📝 `web/src/lib/components/album-page/__tests__/album-card.spec.ts` (+5 -4) 📝 `web/src/lib/components/album-page/album-card.svelte` (+2 -2) 📝 `web/src/lib/components/album-page/album-options.svelte` (+3 -3) 📝 `web/src/lib/components/album-page/album-viewer.svelte` (+1 -1) 📝 `web/src/lib/components/album-page/share-info-modal.svelte` (+1 -2) 📝 `web/src/lib/components/album-page/thumbnail-selection.svelte` (+1 -1) 📝 `web/src/lib/components/asset-viewer/activity-status.svelte` (+1 -1) _...and 80 more files_ </details> ### 📄 Description @jrasm91 has been doing a great job migrating the API over. One of the TODOs from https://github.com/immich-app/immich/pull/7103 was enums. I got that setup and working in this PR. I only migrated a single enum as a demonstration to avoid creating merge conflicts with his outstanding PR Looks like this is causing a bunch of type errors, so there are a bunch of places we'll need to update imports from `@api` to `@immich/sdk`. It's probably best to wait for https://github.com/immich-app/immich/pull/7103 before doing that. Feel free to take this over as I have a busy day tomorrow or else I'll get back to it later in the week --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:40:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?