immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #7076] [MERGED] feat(server,web) Semantic import path validation #11468

New Issue
Closed
opened 2026-02-05 14:40:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:40:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7076
Author: @etnoy
Created: 2/13/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @alextran1502

Base: main ← Head: fix/validate-import-path

📝 Commits (10+)

📊 Changes

32 files changed (+1472 additions, -75 deletions)

View changed files

📝 docs/docs/features/libraries.md (+9 -8)
📝 mobile/openapi/.openapi-generator/FILES (+9 -0)
📝 mobile/openapi/README.md (+4 -0)
📝 mobile/openapi/doc/LibraryApi.md (+58 -0)
➕ mobile/openapi/doc/ValidateLibraryDto.md (+16 -0)
➕ mobile/openapi/doc/ValidateLibraryImportPathResponseDto.md (+17 -0)
➕ mobile/openapi/doc/ValidateLibraryResponseDto.md (+15 -0)
📝 mobile/openapi/lib/api.dart (+3 -0)
📝 mobile/openapi/lib/api/library_api.dart (+52 -0)
📝 mobile/openapi/lib/api_client.dart (+6 -0)
➕ mobile/openapi/lib/model/validate_library_dto.dart (+108 -0)
➕ mobile/openapi/lib/model/validate_library_import_path_response_dto.dart (+122 -0)
➕ mobile/openapi/lib/model/validate_library_response_dto.dart (+97 -0)
📝 mobile/openapi/test/library_api_test.dart (+5 -0)
➕ mobile/openapi/test/validate_library_dto_test.dart (+32 -0)
➕ mobile/openapi/test/validate_library_import_path_response_dto_test.dart (+37 -0)
➕ mobile/openapi/test/validate_library_response_dto_test.dart (+27 -0)
📝 open-api/immich-openapi-specs.json (+98 -0)
📝 open-api/typescript-sdk/axios-client/api.ts (+159 -0)
📝 open-api/typescript-sdk/fetch-client.ts (+25 -0)

...and 12 more files

📄 Description

Check if import paths are valid and warn user if they aren't.

This should help some users to prevent simple mistakes I've seen several times in discord

  • Does the path exist?
  • Is the path a directory?
  • Do we have read access?

When scanning the library, import paths that do not pass validation are ignored

image

We also pop up a notification when the validation button is clicked
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7076 **Author:** [@etnoy](https://github.com/etnoy) **Created:** 2/13/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/validate-import-path` --- ### 📝 Commits (10+) - [`e222ed9`](https://github.com/immich-app/immich/commit/e222ed94fafa72cca1c5a94a5c52d95479cf6cf5) add library validation api - [`646602e`](https://github.com/immich-app/immich/commit/646602e8eb88f4468cb3e7a815f0ece5a31f367b) chore: open api - [`c59d903`](https://github.com/immich-app/immich/commit/c59d9037100190154b89032104e013421aae7504) show warning i UI - [`3cab024`](https://github.com/immich-app/immich/commit/3cab0242d397b7e8e912e2c3539b056e53bd63d6) Merge branch 'main' of https://github.com/immich-app/immich into fix/validate-import-path - [`7787a38`](https://github.com/immich-app/immich/commit/7787a38a786307a0e4603e6d4851590eba2900db) add flex row - [`faedb27`](https://github.com/immich-app/immich/commit/faedb27eec712215b6b62c2226bb677ea7152b40) fix e2e - [`d1b714b`](https://github.com/immich-app/immich/commit/d1b714b0f108fabe3e26760dbe194e2295bd6098) Merge branch 'main' of https://github.com/immich-app/immich into fix/validate-import-path - [`20c241d`](https://github.com/immich-app/immich/commit/20c241dd1ccfb8cc7ff559e04143e491899a9dba) tests - [`65f0612`](https://github.com/immich-app/immich/commit/65f06125adeddf1dd53c62a8c8693e9c15bda98e) fix tests - [`beaddc4`](https://github.com/immich-app/immich/commit/beaddc4ee4dcf0e692f2308d75096a85b0c2e54e) Merge branch 'main' of https://github.com/immich-app/immich into fix/validate-import-path ### 📊 Changes **32 files changed** (+1472 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `docs/docs/features/libraries.md` (+9 -8) 📝 `mobile/openapi/.openapi-generator/FILES` (+9 -0) 📝 `mobile/openapi/README.md` (+4 -0) 📝 `mobile/openapi/doc/LibraryApi.md` (+58 -0) ➕ `mobile/openapi/doc/ValidateLibraryDto.md` (+16 -0) ➕ `mobile/openapi/doc/ValidateLibraryImportPathResponseDto.md` (+17 -0) ➕ `mobile/openapi/doc/ValidateLibraryResponseDto.md` (+15 -0) 📝 `mobile/openapi/lib/api.dart` (+3 -0) 📝 `mobile/openapi/lib/api/library_api.dart` (+52 -0) 📝 `mobile/openapi/lib/api_client.dart` (+6 -0) ➕ `mobile/openapi/lib/model/validate_library_dto.dart` (+108 -0) ➕ `mobile/openapi/lib/model/validate_library_import_path_response_dto.dart` (+122 -0) ➕ `mobile/openapi/lib/model/validate_library_response_dto.dart` (+97 -0) 📝 `mobile/openapi/test/library_api_test.dart` (+5 -0) ➕ `mobile/openapi/test/validate_library_dto_test.dart` (+32 -0) ➕ `mobile/openapi/test/validate_library_import_path_response_dto_test.dart` (+37 -0) ➕ `mobile/openapi/test/validate_library_response_dto_test.dart` (+27 -0) 📝 `open-api/immich-openapi-specs.json` (+98 -0) 📝 `open-api/typescript-sdk/axios-client/api.ts` (+159 -0) 📝 `open-api/typescript-sdk/fetch-client.ts` (+25 -0) _...and 12 more files_ </details> ### 📄 Description Check if import paths are valid and warn user if they aren't. This should help some users to prevent simple mistakes I've seen several times in discord * Does the path exist? * Is the path a directory? * Do we have read access? When scanning the library, import paths that do not pass validation are ignored ![image](https://github.com/immich-app/immich/assets/135728/01b59020-5e94-4ac1-895f-c2425a1bf4b2) We also pop up a notification when the validation button is clicked ![image](https://github.com/immich-app/immich/assets/135728/a6257a3b-2fc2-447a-b541-7970c8a9d541) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:40:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?