immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #6765] [MERGED] refactor: authentication on public routes #11337

New Issue
Closed
opened 2026-02-05 14:37:38 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:37:38 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/6765
Author: @martabal
Created: 1/30/2024
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @jrasm91

Base: main ← Head: refactor/authentication-public-routes

📝 Commits (10+)

📊 Changes

16 files changed (+91 additions, -74 deletions)

View changed files

📝 server/e2e/api/specs/auth.e2e-spec.ts (+2 -1)
📝 server/src/domain/auth/auth.constant.ts (+1 -0)
📝 server/src/domain/auth/auth.service.ts (+5 -1)
📝 server/src/immich/controllers/auth.controller.ts (+2 -0)
📝 server/test/fixtures/auth.stub.ts (+3 -0)
📝 web/src/lib/components/forms/login-form.svelte (+0 -1)
📝 web/src/lib/components/shared-components/navigation-bar/account-info-panel.svelte (+12 -15)
📝 web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte (+1 -1)
📝 web/src/lib/components/user-settings-page/user-profile-settings.svelte (+19 -13)
📝 web/src/lib/components/user-settings-page/user-settings-list.svelte (+1 -1)
📝 web/src/lib/stores/user.store.ts (+1 -9)
📝 web/src/lib/stores/websocket.ts (+3 -4)
📝 web/src/lib/utils/auth.ts (+34 -22)
📝 web/src/routes/(user)/share/[key]/+page.ts (+2 -2)
📝 web/src/routes/+page.ts (+2 -2)
📝 web/src/routes/auth/change-password/+page.ts (+3 -2)

📄 Description

This PR aims to refactor the authentication on public routes to avoid 400 requests on shared links

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/6765 **Author:** [@martabal](https://github.com/martabal) **Created:** 1/30/2024 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `refactor/authentication-public-routes` --- ### 📝 Commits (10+) - [`632469e`](https://github.com/immich-app/immich/commit/632469e61c8284b1076e16b45757b963fb4fb0e7) refactor: authentication on public routes - [`388314f`](https://github.com/immich-app/immich/commit/388314f75f5cb2e6eeef96c55f1524d5405a6aae) fix: remove public user - [`5872e2e`](https://github.com/immich-app/immich/commit/5872e2e62df2a534550fe653af8148af9a287539) pr feedback - [`c96d1a3`](https://github.com/immich-app/immich/commit/c96d1a3c1c26a5b8e585101361f557c89318269a) pr feedback - [`494292d`](https://github.com/immich-app/immich/commit/494292dbe1536395f828f5a0ec6193ccabea4055) pr feedback - [`77f768a`](https://github.com/immich-app/immich/commit/77f768a62d68073533c3f3fcbb82314252544af4) pr feedback - [`ba19728`](https://github.com/immich-app/immich/commit/ba19728913170a61ccf70aca2d1587acc99f6d0e) remove unused method - [`ae8d18d`](https://github.com/immich-app/immich/commit/ae8d18ddc2d4823567ef11c14cb57cc57ad1627e) fix: tests - [`2d59440`](https://github.com/immich-app/immich/commit/2d594408ffaae79f9c0b152d135d2a5cd364e9f9) fix: useless methods - [`ec713a3`](https://github.com/immich-app/immich/commit/ec713a32121cd6a4de6dec7b4de7f6fb6275d738) fix: tests ### 📊 Changes **16 files changed** (+91 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `server/e2e/api/specs/auth.e2e-spec.ts` (+2 -1) 📝 `server/src/domain/auth/auth.constant.ts` (+1 -0) 📝 `server/src/domain/auth/auth.service.ts` (+5 -1) 📝 `server/src/immich/controllers/auth.controller.ts` (+2 -0) 📝 `server/test/fixtures/auth.stub.ts` (+3 -0) 📝 `web/src/lib/components/forms/login-form.svelte` (+0 -1) 📝 `web/src/lib/components/shared-components/navigation-bar/account-info-panel.svelte` (+12 -15) 📝 `web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte` (+1 -1) 📝 `web/src/lib/components/user-settings-page/user-profile-settings.svelte` (+19 -13) 📝 `web/src/lib/components/user-settings-page/user-settings-list.svelte` (+1 -1) 📝 `web/src/lib/stores/user.store.ts` (+1 -9) 📝 `web/src/lib/stores/websocket.ts` (+3 -4) 📝 `web/src/lib/utils/auth.ts` (+34 -22) 📝 `web/src/routes/(user)/share/[key]/+page.ts` (+2 -2) 📝 `web/src/routes/+page.ts` (+2 -2) 📝 `web/src/routes/auth/change-password/+page.ts` (+3 -2) </details> ### 📄 Description This PR aims to refactor the authentication on public routes to avoid 400 requests on shared links --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:37:38 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?